Skip to content

[cherry-pick v20260107] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8573

Open
djsly wants to merge 1 commit into
official/v20260107from
djsly/icm-796913379-cve-go-1.25.10-v20260107
Open

[cherry-pick v20260107] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8573
djsly wants to merge 1 commit into
official/v20260107from
djsly/icm-796913379-cve-go-1.25.10-v20260107

Conversation

@djsly
Copy link
Copy Markdown
Collaborator

@djsly djsly commented May 22, 2026

Summary

Cherry-pick of #8551 to official/vv20260107.

Bumps the Go toolchain and golang.org/x/net to address upstream CVEs:

Vulnerability CVE Component Fixed by
net/mail DoS via crafted addresses CVE-2026-39820 net/mail (stdlib) Go 1.25.10
cmd/go pack subcommand directory traversal CVE-2026-39817 cmd/go (stdlib) Go 1.25.10
HTTP/2 + IPv6 host parsing fixes (various, see x/net release notes) golang.org/x/net v0.55.0

Why bump to Go 1.25 (and not a 1.24.x patch)

Go 1.24 reached EOL in February 2026 and does NOT receive security backports. go1.25.10 is the only release stream that contains these fixes.

golang.org/x/net v0.51.0+ also requires go 1.25.0 in its own go.mod, so the Go bump is required regardless.

Verification

  • go mod tidy succeeds for every module in the branch.
  • go build ./... clean across every module.
  • PR CI must pull go 1.25 runners.

Release plan

Once merged, two tags are pushed off the resulting commit:

  • v0.v20260107.<N+1> (AgentBaker module)
  • aks-node-controller/v0.v20260107.<N+1> (aks-node-controller submodule)

🤖 Generated with GitHub Copilot CLI

Backport the Go 1.25.10 and golang.org/x/net v0.55.0 CVE fix from #8551 to official/v20260107.

IcM 796913379.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates AgentBaker’s Go toolchain and key Go dependencies on official/vv20260107 to pick up upstream security fixes, and aligns CI workflows to use the new Go minor version.

Changes:

  • Bump all Go modules’ go directive to 1.25.10.
  • Bump golang.org/x/net (and related x/* transitive deps via tidy) in the main modules (/, e2e/, aks-node-controller/).
  • Update GitHub Actions workflows to use Go 1.25.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Bump root module Go version and golang.org/x/net/x/* indirect deps.
go.sum Update checksums to reflect the x/net (and related) upgrades.
e2e/go.mod Bump Go version and update x/crypto + x/* indirect deps for e2e module.
e2e/go.sum Update e2e dependency checksums for the upgraded x/* deps.
aks-node-controller/go.mod Bump Go version and refresh x/sys indirect dependency.
aks-node-controller/go.sum Update checksums to match upgraded x/* dependencies.
vhdbuilder/lister/go.mod Bump Go version (note: still pins older indirect x/* versions).
vhdbuilder/prefetch/go.mod Bump Go version for the prefetch module.
hack/tools/go.mod Bump Go version for tooling module (note: tooling graph still appears to pull older x/net).
.github/workflows/check-coverage.yml CI: use Go 1.25.
.github/workflows/go-test.yml CI: use Go 1.25.
.github/workflows/golangci-lint.yml CI: use Go 1.25.
.github/workflows/shellcheck.yml CI: use Go 1.25.
.github/workflows/shellspec.yaml CI: use Go 1.25.
.github/workflows/validate-components.yml CI: use Go 1.25.

Comment thread vhdbuilder/lister/go.mod
Comment on lines 1 to 4
module github.com/Azure/agentbaker/vhdbuilder/lister

go 1.23.0

toolchain go1.24.1
go 1.25.10

Comment thread hack/tools/go.mod
Comment on lines 1 to 4
module github.com/Azure/agentbaker/hack/tools

go 1.21.13
go 1.25.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants