[cherry-pick v20251218] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8562
Open
djsly wants to merge 1 commit into
Open
[cherry-pick v20251218] fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8562djsly wants to merge 1 commit into
djsly wants to merge 1 commit into
Conversation
Backport of the patch from #8551 to official/v20251218 for IcM 796913379. Fixes CVE-2026-39820 (net/mail DoS) and CVE-2026-39817 (cmd/go pack traversal). Go 1.24 reached EOL Feb 2026 with no security backports — Go 1.25.10 is the only release stream with these fixes. IcM: 796913379 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
djsly
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the security remediation from #8551 onto official/v20251218 by upgrading the Go toolchain version used across the repo and updating golang.org/x/net (and related x/* modules) plus CI workflows to run on Go 1.25.
Changes:
- Bump all module
godirectives togo 1.25.10across the repo’s multiple Go modules. - Update
golang.org/x/nettov0.55.0(and refresh associatedgo.sumentries where applicable). - Update GitHub Actions workflows to use Go
1.25.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Bumps root module to Go 1.25.10 and updates indirect golang.org/x/* versions. |
| go.sum | Refreshes sums after golang.org/x/* dependency bumps. |
| e2e/go.mod | Bumps e2e module to Go 1.25.10; updates x/crypto and indirect x/* versions. |
| e2e/go.sum | Refreshes sums after e2e dependency bumps. |
| aks-node-controller/go.mod | Bumps module to Go 1.25.10 and updates indirect x/sys. |
| aks-node-controller/go.sum | Refreshes sums after dependency bumps. |
| vhdbuilder/prefetch/go.mod | Bumps module to Go 1.25.10. |
| vhdbuilder/lister/go.mod | Bumps module to Go 1.25.10; removes toolchain directive. |
| hack/tools/go.mod | Bumps module to Go 1.25.10. |
| .github/workflows/check-coverage.yml | Updates CI Go version to 1.25. |
| .github/workflows/go-test.yml | Updates CI Go version to 1.25. |
| .github/workflows/golangci-lint.yml | Updates CI Go version to 1.25. |
| .github/workflows/shellcheck.yml | Updates CI Go version to 1.25. |
| .github/workflows/shellspec.yaml | Updates CI Go version to 1.25. |
| .github/workflows/validate-components.yml | Updates CI Go version to 1.25. |
Comment on lines
1
to
4
| module github.com/Azure/agentbaker/vhdbuilder/lister | ||
|
|
||
| go 1.23.0 | ||
|
|
||
| toolchain go1.24.1 | ||
| go 1.25.10 | ||
|
|
djsly
changed the title
Devinwong
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #8551 to
official/vv20251218.Bumps the Go toolchain and
golang.org/x/netto address upstream CVEs:net/mail(stdlib)cmd/gopacksubcommand directory traversalcmd/go(stdlib)golang.org/x/netWhy bump to Go 1.25 (and not a 1.24.x patch)
Go 1.24 reached EOL in February 2026 and does NOT receive security backports.
go1.25.10is the only release stream that contains these fixes.golang.org/x/net v0.51.0+also requiresgo 1.25.0in its owngo.mod, so the Go bump is required regardless.Verification
go mod tidysucceeds for every module in the branch.go build ./...clean across every module.go 1.25runners.Release plan
Once merged, two tags are pushed off the resulting commit:
v0.v20251218.<N+1>(AgentBaker module)aks-node-controller/v0.v20251218.<N+1>(aks-node-controller submodule)🤖 Generated with GitHub Copilot CLI