Fix maven dependency issues#16
Open
jbauerrfid wants to merge 3 commits intoAzure-Samples:masterfrom
Open
Conversation
|
|
Member
|
@conniey - Can you have a look? |
1 similar comment
Member
|
@conniey - Can you have a look? |
conniey
reviewed
Oct 22, 2021
| <artifactId>azure-storage-common</artifactId> | ||
| <version>12.0.0</version> | ||
| </dependency> | ||
| <groupId>com.azure</groupId> |
There was a problem hiding this comment.
Ideally, we would be referencing the BOM (azure-sdk-bom) so that the dependencies are aligned. azure-storage-blob transitively brings in azure-storage-common so you do not need to explicitly reference this.
https://search.maven.org/artifact/com.azure/azure-sdk-bom/1.0.5/pom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix problems building the v12 example, caused by a missing pom.xml in the 12.0.0 version. The fix uses newer version of the artifacts, which provide their pom files.
I have provided all changes as individual commits, to allow using them all, or make cherry picks instead.
This relates to #15