-
-
Notifications
You must be signed in to change notification settings - Fork 899
Add campaign data: Journey #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndelangen
wants to merge
53
commits into
Azgaar:master
Choose a base branch
from
ndelangen:norbert/campaign-journey
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
b1151a0
add more testing in preparation of refactors
ndelangen 80ad549
adding the journey feature v0
ndelangen b28e63c
improve visual
ndelangen ce10849
fix(load): harden map parsing and presets for older saves
ndelangen 809db11
add edit feature
ndelangen 6a0796e
also allow markers and burgs to be points
ndelangen c6bc8af
simplify to existing "points" only
ndelangen 6bf720e
add new campaign layer preset
ndelangen 0151a42
allow styling of journey
ndelangen 36de63a
fix initial campaign layer preset not rendering journey
ndelangen 12e9b9b
cleanup
ndelangen 1263053
cleanup
ndelangen ec8a6b4
Enhance readJourneyStyleConfig to preserve zero values for data attri…
ndelangen bedc404
Refactor journey resolution logic to introduce journeyResolvedStopEnt…
ndelangen 728c6a4
Update journey insertion logic to position journeys below routes inst…
ndelangen a9ea014
Implement buildJourneyResolutionContext to enhance journey resolution…
ndelangen 239541d
Refactor journey handling by introducing ensurePackJourneyNormalized …
ndelangen 411627b
Refactor journey resolution context usage in JourneyDrawModule and jo…
ndelangen cf6d207
Update package versions and dependencies; refactor Playwright tests t…
ndelangen 38ff8ea
Discard changes to package.json
ndelangen 7090aad
Discard changes to tests/e2e/burgs.spec.ts
ndelangen 9728b6a
Discard changes to tests/e2e/layers.spec.ts
ndelangen 2e52940
Discard changes to tests/e2e/lakes-layer.spec.ts
ndelangen eb15e8a
Discard changes to tests/e2e/load-map.spec.ts
ndelangen 45d5f4b
Discard changes to tests/e2e/states.spec.ts
ndelangen 10cb526
Discard changes to tests/e2e/zones-export.spec.ts
ndelangen e2e51db
Discard changes to package-lock.json
ndelangen f9259d3
Refactor journey normalization logic to prioritize `stops[]` over leg…
ndelangen 17c0809
Merge remote-tracking branch 'upstream/master' into norbert/campaign-…
ndelangen 9242292
Update package-lock.json and package.json; refactor journey model to …
ndelangen fbbbe38
Discard changes to package.json
ndelangen f2dcf5a
Discard changes to package-lock.json
ndelangen 5ead5b5
Refactor journey model tests to remove legacy handling of `stopIds` a…
ndelangen 94e442f
Refactor journey-draw and journey-model modules to simplify type defi…
ndelangen b46d32b
simplify
ndelangen 3594878
Refactor namesbase-editor and journey modules to utilize escapeHtml f…
ndelangen 64ba9e6
Add editJourney method to global interface and import ensureEl utilit…
ndelangen 112d4d5
Enhance type safety in journey module by explicitly defining the type…
ndelangen 30c115c
allow for many Journeys
ndelangen 8f59e57
linting & formatting
ndelangen 86e7a09
delete normalization
ndelangen ad13398
linting & formatting
ndelangen 22d49eb
Merge pull request #1 from ndelangen/norbert/multi-journey
ndelangen 1be3ceb
improve gradient editing for journeys
ndelangen c2cf4da
Merge pull request #2 from ndelangen/norbert/improve-color-picking-jo…
ndelangen 2ef737f
improve colors gradient display
ndelangen b6a6929
reduce commenting of code to adhere to repo standards
ndelangen 1a21d24
reduce commenting of code to adhere to repo standards
ndelangen 95d800e
improve arrow positioning
ndelangen 1a682b5
ensure journey-legs never overlap, even when from different journeys
ndelangen 58218e4
make naming more consistent
ndelangen fec0a79
Merge branch 'master' into norbert/campaign-journey
ndelangen 5a8ee41
Merge branch 'norbert/campaign-journey' of github.com:ndelangen/Fanta…
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,4 +48,4 @@ | |
| "engines": { | ||
| "node": ">=24.0.0" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.