Added sieging convinience and tweaked some strength values#1408
Open
Palladium103 wants to merge 36 commits into
Open
Added sieging convinience and tweaked some strength values#1408Palladium103 wants to merge 36 commits into
Palladium103 wants to merge 36 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fix: nearest regiment
…ent attempts to initiate another siege
fix: force the type to "siege" to prevent occations where defending regiments veers off to the burg's cell
refactor: putting back some white spaces and layout to its default
fix: fraternal burgs no longer targetable
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
This is the second open of this pr because I messed up with the git, its here if you want to consider it :) |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI and battle-logic support for initiating sieges by clicking directly on burg icons, and tweaks siege strength weighting to emphasize citadels/castles in the battle simulator.
Changes:
- Added a “Attack foreign burg” action in the regiment editor to start a siege by clicking a target burg, selecting the nearest defending regiment to respond.
- Adjusted battle type detection and siege phase strength coefficients to account for burg citadels.
- Minor text/comment wording tweaks in UI and Military module.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/modules/military-generator.ts | Minor wording fix in a comment related to regiment total formatting. |
| src/index.html | Adds a new regiment editor button for burg attacks; updates external image label text. |
| public/modules/ui/regiment-editor.js | Implements the burg-attack (siege initiation) click flow and related UI toggling. |
| public/modules/ui/battle-screen.js | Updates siege detection and adjusts siege strength calculations based on citadel presence; includes some formatting changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a way to directly attack burgs for convinience, when a burg is being sieged, the nearest non-zero regiment will come to aid.
Attempted to try give emphasis to burgs having castles by slightly modifying strengths if the burg has castle.