Avoids querying the DB twice just to get the counts and explicitly use 'COUNT(DISTINCT for faster results

[brunobasto]

Description

We already had a patch to use COUNT(DISTINCT on our fix_found_users_query hook, but that didn't prevent WP from doing the SELECT SQL_CALC_FOUND_ROWS() first.

WordPress will do two queries:

1. To get the results with SELECT SQL_CALC_FOUND_ROWS(): https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user-query.php#L844
2. To get the count: https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user-query.php#L861

Our previous solution only changed the count query, but WP was still doing the first SQL_CALC_FOUND_ROWS as usual.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
• This change has relevant unit tests (if applicable).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

[Copilot]

Pull Request Overview

This PR optimizes user query performance by avoiding WordPress's default dual-query pattern. Instead of letting WordPress run both a SELECT SQL_CALC_FOUND_ROWS() query and a separate count query, the code now manually constructs a single optimized query using COUNT(DISTINCT) when only counts are needed.

• Replaces WP_User_Query instantiation with manual query preparation and construction
• Removes the temporary hook-based solution for fixing found users queries
• Uses direct database queries with COUNT(DISTINCT) for more efficient counting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
utils/class-users-query-utils.php	Modified to manually construct optimized SQL queries instead of using WP_User_Query's dual-query pattern
modules/inactive-users/class-inactive-users.php	Removed temporary hook-based solution that was previously used to fix count queries

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[kat3samsin]

🙏🏻