[PLTFRM-1510] Set highlight-mfa-users to Admin and Editor roles by default#85
Merged
kat3samsin merged 4 commits intoproductionfrom Aug 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the highlight-mfa-users module to default to Admin and Editor roles instead of using configurable capabilities. The change simplifies the configuration by hard-coding the roles to DEFAULT_ADMIN_EDITOR_ROLE_SLUGS and forces the notice display to show "Administrator and Editor" rather than "high privileges".
- Hard-codes the MFA highlighting to apply only to Admin and Editor roles
- Removes the capability-based configuration in favor of role-based defaults
- Forces the notice to display specific role names instead of generic "high privileges" text
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
highlight-mfa-users to Admin and Editor roles by defaulthighlight-mfa-users to Admin and Editor roles by default
171e4bd to
36663f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test