[Highlight MFA] Use roles instead of capabilities#20
Merged
andrea-sdl merged 4 commits intoproductionfrom May 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the use of capabilities with roles for highlighting users who need MFA. The key changes include updating configuration defaults, modifying query parameters in both the unit tests and main class, and adjusting corresponding expected outcomes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/phpunit/test-highlight-mfa-users.php | Updated test assertions and expected user count for roles filter |
| modules/highlight-mfa-users/class-highlight-mfa-users.php | Renamed and replaced capabilities with roles in filtering logic |
Comments suppressed due to low confidence (2)
modules/highlight-mfa-users/class-highlight-mfa-users.php:11
- Update the PHPDoc to reflect that the variable now holds roles instead of capabilities.
* @var array An array of capability slugs.
tests/phpunit/test-highlight-mfa-users.php:127
- Double-check that the test expectations for roles filtering correctly cover all necessary role scenarios. Ensure additional tests exist if additional roles might be used.
$this->assertEquals( [ 'administrator' ], $roles_in_query );
…re with the "edit_post" capabilitiy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we're moving away from capabilities, and then using roles instead to highlight the users who need MFA:
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
vip dev-env create && vip dev-env start