Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the deprecation warning triggered by calling fs.existsSync with non-string arguments by adding explicit type checks before invoking fs.existsSync.
- Add
typeof ... === 'string'guards beforefs.existsSynccalls in various filter chains inlib/lando.js. - Refactor the
exports.loadFilesfilter inlib/config.jsto safely handle both string sources and objects with afileproperty.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/lando.js | Added string-type checks before calling fs.existsSync in multiple filter steps |
| lib/config.js | Replaced simple fs.existsSync calls with a branch that validates source and source.file types |
Comments suppressed due to low confidence (1)
lib/config.js:196
- Consider adding unit tests for
loadFilesto cover cases where inputs are non-strings or objects without afileproperty to ensure the filter logic behaves as expected.
.filter(source => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Passing invalid argument types to fs.existsSync is deprecatedwarning.