Skip to content

uploader: Safeguard against rsync localhost IPv6 targets, and update documentation #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notklea wants to merge 2 commits into
base: master
Choose a base branch
from
Open

uploader: Safeguard against rsync localhost IPv6 targets, and update documentation #610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1b1fea
uploader: Forbid uploads to localhost over IPv6 too
May 2, 2026
d4e92e5
uploader: FOS no longer exists
May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions uploader/uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"""uploader.py: upload WARC files toward the Internet Archive

rsync mode (RSYNC_URL set): upload everything to an rsync endpoint
such as fos.
such as ArchiveTeam targets.

s3 mode (S3_URL set): upload everything directly to the Internet Archive

Expand Down Expand Up @@ -36,7 +36,8 @@ def __init__(self):

self.url = os.environ.get('RSYNC_URL')
if self.url != None:
if '/localhost' in self.url or '/127.' in self.url:
local_urls = ['/localhost','/127.','/[::1]']
if any(local_url in self.url for local_url in local_urls):
raise RuntimeError('Won\'t let you upload to localhost because I '
'remove files after uploading them, and you '
'might be uploading to the same directory')
Expand Down