Draft
Conversation
Hugobros3
force-pushed
the
feature/thorin-tests
branch
from
31c816a to
1ed0690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving some more code from my abandoned 2023 Thorin branch.
This test suite aggressively validates closure conversion, lifting and other fragile behavior in Thorin. That is to say, on thorin's master branch, most of these tests fail hard! I suggest using these failing tests as a target for future rewrites.
Additionally, this PR introduces infrastructure to validate the correctness of our code generation (C, LLVM, SPIR-V), including validation that our intrinsic emission works.