Skip to content

[O2B-1559] Warn the user of mutated filters when loading the url#2145

Open
NarrowsProjects wants to merge 6 commits intofeature/O2B-1558/Set-filters-from-URL-upon-page-reloadfrom
feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url
Open

[O2B-1559] Warn the user of mutated filters when loading the url#2145
NarrowsProjects wants to merge 6 commits intofeature/O2B-1558/Set-filters-from-URL-upon-page-reloadfrom
feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 28, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When the user navigates to an overview page with filters that do not exist, the page will have an orange bar below the toolbar that says 'warnings' allong with the relevant warnings

Notable changes for developers:

  • overviewModel and LogsOverviewModel have a object state now called _warnings

Changes made to the database:

  • N/A

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.73%. Comparing base (e157e08) to head (33291b6).

Files with missing lines Patch % Lines
...lic/components/common/messages/warningComponent.js 0.00% 9 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 8 Missing ⚠️
lib/public/models/OverviewModel.js 0.00% 4 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 3 Missing ⚠️
...riodOverview/DataPassesPerLhcPeriodOverviewPage.js 0.00% 2 Missing ⚠️
...verview/DataPassesPerSimulationPassOverviewPage.js 0.00% 2 Missing ⚠️
lib/public/views/LhcFills/Overview/index.js 0.00% 2 Missing ⚠️
lib/public/views/Logs/Overview/index.js 0.00% 2 Missing ⚠️
...ws/QcFlagTypes/Overview/QcFlagTypesOverviewPage.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/Overview/RunsOverviewPage.js 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           feature/O2B-1558/Set-filters-from-URL-upon-page-reload    #2145      +/-   ##
==========================================================================================
- Coverage                                                   45.80%   45.73%   -0.08%     
==========================================================================================
  Files                                                        1036     1037       +1     
  Lines                                                       17194    17222      +28     
  Branches                                                     3128     3131       +3     
==========================================================================================
  Hits                                                         7876     7876              
- Misses                                                       9318     9346      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url branch from 3562473 to ee42c74 Compare April 28, 2026 13:47
@NarrowsProjects NarrowsProjects self-assigned this Apr 28, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 28, 2026
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url branch from ee42c74 to 4a00d0f Compare April 29, 2026 08:23
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1558/Set-filters-from-URL-upon-page-reload branch from 82c8d41 to e157e08 Compare April 29, 2026 08:41
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url branch 3 times, most recently from 46ba10a to a904fe5 Compare April 29, 2026 09:57
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url branch from a904fe5 to 2c79c9f Compare April 29, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant