Merged
Conversation
Updates model loading to utilize shared pointers for improved memory management. Moves MMD data path error logging to a more appropriate class, enhancing code organization. Refactors camera motion loading and saving by leveraging the saba library, resulting in more efficient and maintainable code. Adds a dedicated MMDCamera object type with conversion and keyframe functionalities, improving camera management.
Refactors MMDCamera to use more descriptive member names (camera_ and protection_tag_). This improves code readability and maintainability. Also, updates the unique ID string for the camera object.
Updated submodule dependency/saba
Replaces the direct loading of PMX data within the CMTToolsManager with a new approach that utilizes `saba::ReadPMXFile` for initial file reading and `PMXModel::LoadPMX` for processing. This change improves code organization and separation of concerns, making the loading process more modular and maintainable. It also removes the dependency on PMD model loading.
Streamlines I/O logging by replacing `Log` variables with `logger` within the scope they are used. Improves PMX model loading by passing `PMXFile` into the `LoadModelLog::Set` function to retrieve the vertex count and load bones. Removes unused `vmd_interpolator` files. Updates dependency `saba`.
Streamlines the creation and updating of MMD manager objects (Bone, Mesh, Rigid, Joint) within the MMDModelManager. This includes: - Passing the MMDModel pointer down to the individual managers. - Adding CreateManagers function to instantiate manager objects. - Modifying manager update logic to ensure correct initialization and object assignment. - Passing MMDPhysicsManager down to Joint and Rigid managers. These changes improve the overall structure and data flow of the MMD model management system.
Replaces `#ifndef` header guards with `#pragma once` in multiple header files for improved readability and potential performance benefits. Updates object and scene hook IDs to use constexpr auto instead of #define. Refactors object hierarchy management in `MMDJointObject` and `MMDRigidObject` to improve robustness and maintainability. Addresses potential object lifetime issues related to bone tag management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.