test: add config CRUD unit tests#597
Conversation
|
Developer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
9112f82 to
c20200b
Compare
|
@MD-Mushfiqur123 thank for the contribution, if you could sign the CLA agreement I can get started on the review |
|
Quick heads-up: this is going to conflict with #606. Both PRs add Please coordinate so we keep one version of this test file. Otherwise one of the two PRs will be stale even before CLA is sorted out. |
santoshkumarradha
left a comment
There was a problem hiding this comment.
Thanks for filling in config-storage coverage here. I pulled the branch locally and checked it against main, and the main issue is that this file mostly duplicates scenarios we already exercise in existing tests.
TestLocalStorageConfigLifecycle already covers the SQLite path for insert, update/version bump, lexical list order, delete, missing delete, and canceled context. We also already cover the postgres branch in coverage_storage_clinch_test.go. Adding a second full CRUD suite for the same behavior makes this area harder to maintain without giving us much new signal.
Can you tighten this down to only the cases that are genuinely missing from current coverage, or extend the existing test(s) instead of introducing a parallel suite? Once that overlap is removed, I’m happy to take another look.
|
|
||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Most of this new file overlaps with coverage we already have on main. TestLocalStorageConfigLifecycle in local_vector_config_pubsub_test.go already exercises the SQLite config CRUD path, and coverage_storage_clinch_test.go covers the postgres branch too. Can we fold any truly missing assertions into those existing tests instead of adding a second end-to-end CRUD suite here?
Closes #391
Adds table-driven Go tests for LocalStorage config CRUD operations: SetConfig, GetConfig, ListConfigs, DeleteConfig.
10 test cases covering:
PR generated by AI agent.