-
Notifications
You must be signed in to change notification settings - Fork 0
fix(process): rework #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
siriuslatte
wants to merge
5
commits into
main
Choose a base branch
from
processes-rework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(process): rework #108
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a87ad55
feat(process): remove old processes + add new ones
siriuslatte 2e3c557
fix(process): build problem
siriuslatte f01ab8f
fix & tests(process): fix & write tests
siriuslatte 7803730
feat(process): rework process again
siriuslatte eb44a23
fix(process): scheduler set
siriuslatte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| /// <reference types="@rbxts/testez/globals" /> | ||
|
|
||
| export = (): void => {}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { EventEmitter } from "../../events"; | ||
| import { Scheduler } from "../scheduler"; | ||
| import { TProcessStatus } from "../scheduler/types"; | ||
| import { IProcessImplementation } from "./types"; | ||
|
|
||
| interface IProcessEvent { | ||
| _default: [dt: number]; | ||
| } | ||
|
|
||
| export class Process extends EventEmitter<IProcessEvent> implements IProcessImplementation { | ||
| public lastTick: number = os.clock(); | ||
|
|
||
| public ticksPerSecond?: number; | ||
|
|
||
| constructor(public readonly name: string, public readonly executionGroup?: RBXScriptSignal) { | ||
| super(); | ||
|
|
||
| Scheduler.add(name, this); | ||
| } | ||
|
|
||
| public resume(): void { | ||
| return Scheduler.unsuspend(this.name); | ||
| } | ||
|
|
||
| public suspend(ticks: number): void { | ||
| return Scheduler.suspend(this.name, ticks); | ||
| } | ||
|
|
||
| public status(): TProcessStatus { | ||
| return Scheduler.status(this.name); | ||
| } | ||
|
|
||
| public _update(dt: number): void { | ||
| return this.emit("_default", dt); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { TProcessStatus } from "../scheduler/types"; | ||
|
|
||
| export interface IProcessImplementation { | ||
| /** | ||
| * Initializes current process. | ||
| */ | ||
| resume(): void; | ||
|
|
||
| /** | ||
| * Suspends the current process by the given ticks, defaults to 1. | ||
| * | ||
| * @param ticks the amount of ticks to suspend the process. | ||
| */ | ||
| suspend(ticks: number): void; | ||
|
|
||
| /** | ||
| * Returns the current status of the process. | ||
| * | ||
| * @returns A string for it's status. | ||
| */ | ||
| status(): TProcessStatus; | ||
|
|
||
| /** | ||
| * @hidden (internal usage, DO NOT USE) | ||
| */ | ||
| _update(dt: number): void; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can execution group be the same as in the ECS? It seems weird to have the same name in two places but supporting different functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking on this as well, I was going to discuss this with Luna, if processes can be the same as Systems as in the ECS.