Copy MiniRust's variant tag representation - #1154
Merged
Merged
Conversation
Nadrieril
force-pushed
the
discriminant-repr
branch
from
May 13, 2026 12:23
fb6b704 to
74514e7
Compare
For convenience on the OCaml side.
Nadrieril
force-pushed
the
discriminant-repr
branch
from
May 13, 2026 12:41
74514e7 to
40092c9
Compare
Nadrieril
enabled auto-merge
May 13, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the idea discussed in #1046 to reuse MiniRust's discriminant encoding representation.
This PR preserves previous (incorrect) semantics, see #1046. Fixing that is left to a subsequent PR.
cc @N1ark @firefighterduck