fix(security): 2 improvements across 2 files#807
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Path traversal/arbitrary file write via unsanitized service ID - Security: Prototype pollution risk in service merge logic Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Path traversal/arbitrary file write via unsanitized service ID - Security: Prototype pollution risk in service merge logic Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:scripts/services/restore-removed-services.js:L26When restoring removed services, the output file path is built using
removedObject.iddirectly. BecauseserviceSchemaonly enforcesidas a string (no path-safe pattern), anidlike../../.github/workflows/pwncould cause writes outsidesourceDirPathduring build execution.Solution
Validate
removedObject.idagainst a strict allowlist regex (e.g.^[a-z0-9_-]+$), build paths withpath.resolve(sourceDirPath, ...), and enforce that the resolved path starts with the resolvedsourceDirPathbefore writing.Changes
scripts/services/restore-removed-services.js(modified)scripts/services/merge-services-data.js(modified)