feat: add pain.001.001.09/13 and pain.008.001.08/12 support#1
Merged
Conversation
….001.12 support - Add support for ISO 20022 newer schema versions (.09/.13 for credit transfers, .08/.12 for direct debits) using official ISO XSDs - Use BICFI element instead of BIC for newer schemas (ISO renaming) - Use nested ReqdExctnDt/Dt structure for pain.001.001.09+ - Fix PR #117 bug: use group[:account].bic (not account.bic) in direct_debit.rb CdtrAgt block to preserve per-group creditor BIC - Add 24 new XSD validation tests (228 total, 0 failures, 100% coverage) - Include AUDIT.md with comprehensive gem audit findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pain.001.001.09,pain.001.001.13,pain.008.001.08,pain.008.001.12group[:account].bicindirect_debit.rbCdtrAgt block (PR #117 introduced a regression usingaccount.bic, emitting wrong BIC for per-transaction creditor accounts)Key changes
BIC→BICFIelement for newer schemas (ISO 20022 renaming)ReqdExctnDt/Dtstructure for pain.001.001.09+ (DateAndDateTime2Choice)AUDIT.mdwith remaining improvement itemsContext
Older pain.001.001.03 / pain.008.001.02 versions become obsolete in November 2026. CFONB (France) recommends .09/.08 for new implementations since 2023.
Test plan