Skip to content

Add HDF5 option to configure script and add environment variables for configuring HDF5#5392

Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
mcmehrtens:add-hdf5-to-configure
May 5, 2026
Merged

Add HDF5 option to configure script and add environment variables for configuring HDF5#5392
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
mcmehrtens:add-hdf5-to-configure

Conversation

@mcmehrtens
Copy link
Copy Markdown
Contributor

@mcmehrtens mcmehrtens commented Apr 28, 2026

Summary

  • Resolves Extending HDF5 Support #5391
  • Adds an --hdf5 flag to the configure script to allow configuring AMReX with HDF5 support
  • Adds two new environment variables:
    • HDF5_ALIGNMENT_SIZE which is passed to H5Pset_alignment()
    • HDF5_BLOCK_SIZE which is passed to H5Pset_meta_block_size()

Additional background

  • The two new environment variables mirror how the other HDF5 configuration option is currently set.
  • If we want to move forward with these changes, I will add appropriate documentation before taking the PR out of draft.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@mcmehrtens mcmehrtens force-pushed the add-hdf5-to-configure branch from 31da05f to 7df7e08 Compare May 5, 2026 14:42
@mcmehrtens
Copy link
Copy Markdown
Contributor Author

fixed whitespace & rebased off development

@WeiqunZhang
Copy link
Copy Markdown
Member

LGTM. The Windows CI issues are not due to this PR. So is this still a work in progress?

@mcmehrtens
Copy link
Copy Markdown
Contributor Author

LGTM. The Windows CI issues are not due to this PR. So is this still a work in progress?

Sounds good. I need to update the documentation and then I will take it out of draft and request review. I didn't want to add documentation until it had your preliminary review of the PR/issue.

@mcmehrtens mcmehrtens marked this pull request as ready for review May 5, 2026 17:31
@mcmehrtens
Copy link
Copy Markdown
Contributor Author

@WeiqunZhang ready for your final review after CI tests run

@WeiqunZhang WeiqunZhang merged commit 78fbf4e into AMReX-Codes:development May 5, 2026
71 of 73 checks passed
@mcmehrtens mcmehrtens deleted the add-hdf5-to-configure branch May 5, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extending HDF5 Support

2 participants