Add HDF5 option to configure script and add environment variables for configuring HDF5#5392
Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom May 5, 2026
Merged
Conversation
31da05f to
7df7e08
Compare
Contributor
Author
|
fixed whitespace & rebased off development |
Member
|
LGTM. The Windows CI issues are not due to this PR. So is this still a work in progress? |
Contributor
Author
Sounds good. I need to update the documentation and then I will take it out of draft and request review. I didn't want to add documentation until it had your preliminary review of the PR/issue. |
Contributor
Author
|
@WeiqunZhang ready for your final review after CI tests run |
WeiqunZhang
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--hdf5flag to theconfigurescript to allow configuring AMReX with HDF5 supportHDF5_ALIGNMENT_SIZEwhich is passed toH5Pset_alignment()HDF5_BLOCK_SIZEwhich is passed toH5Pset_meta_block_size()Additional background
If we want to move forward with these changes, I will add appropriate documentation before taking the PR out of draft.Checklist
The proposed changes:
fix a bug or incorrect behavior in AMReXchanges answers in the test suite to more than roundoff levelare likely to significantly affect the results of downstream AMReX users