Skip to content

Fix #1636 by updating gqlparser#1857

Merged
StevenACoffman merged 1 commit into
masterfrom
update_parser
Jan 26, 2022
Merged

Fix #1636 by updating gqlparser#1857
StevenACoffman merged 1 commit into
masterfrom
update_parser

Conversation

@StevenACoffman
Copy link
Copy Markdown
Collaborator

@StevenACoffman StevenACoffman commented Jan 26, 2022

This fixes #1636 and updates to gqlparser v2.3.1

Signed-off-by: Steve Coffman steve@khanacademy.org

@StevenACoffman StevenACoffman marked this pull request as draft January 26, 2022 14:16
@StevenACoffman StevenACoffman added the help wanted Extra attention is needed label Jan 26, 2022
@StevenACoffman
Copy link
Copy Markdown
Collaborator Author

Something weird is going on. I get problems for every gqlparser version down to v2.2.0:

#!/bin/bash
# exit if any command fails:
set -e

array=( $(git log v2.2.0..v2.3.0 --pretty=format:"%h") )

for i in "${array[@]}"
do
	echo "$i"
    go get -d github.com/vektah/gqlparser/v2@$i
    go mod tidy
    cd example
    go get -d github.com/vektah/gqlparser/v2@$i
    go mod tidy
    cd ..
    go generate ./... && cd example && go generate ./... && cd ..
done

@StevenACoffman
Copy link
Copy Markdown
Collaborator Author

StevenACoffman commented Jan 26, 2022

It looks like the vektah/gqlparser#168 PR by @wilhelmeek causes a problem. Hopefully he can make another run at that work in a later PR as I'm going to revert it.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 74.997% when pulling 0ec978a on update_parser into c161ab3 on master.

@StevenACoffman
Copy link
Copy Markdown
Collaborator Author

So I needed to revert the vektah/gqlparser#168 PR by @wilhelmeek and cut a v2.3.1 over there as it caused problems here and in genqlient.

Upgrading the gqlparser to v2.3.0 causes these problems:

$ go generate ./...; cd example; go generate ./...
Generated github.com/99designs/gqlgen/codegen/testserver/followschema in 4.04s
Generated github.com/99designs/gqlgen/codegen/testserver/singlefile in 1.64s
Generated github.com/99designs/gqlgen/integration in 1.17s
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/plugin/federation/testdata/entityresolver/prelude.resolvers.go:19:39: __TypeResolver not exported by package generated

exit status 3
plugin/federation/federation_entityresolver_test.go:1: running "go": exit status 1
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/chat/resolvers.go:35:14: cannot use &(resolver literal) (value of type *resolver) as ResolverRoot value in struct literal: missing method __Type

exit status 3
chat/resolvers.go:1: running "go": exit status 1
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/config/prelude.resolvers.go:20:6: __TypeResolver redeclared in this block
/Users/steve/Documents/git/gqlgen/example/config/generated.go:84:6: 	other declaration of __TypeResolver
/Users/steve/Documents/git/gqlgen/example/config/prelude.resolvers.go:13:7: invalid receiver *__TypeResolver (pointer or interface type)
/Users/steve/Documents/git/gqlgen/example/config/generated.go:1949:32: cannot call pointer method SpecifiedByURL on __TypeResolver
/Users/steve/Documents/git/gqlgen/example/config/prelude.resolvers.go:18:54: invalid composite literal type __TypeResolver

exit status 3
config/resolver.go:1: running "go": exit status 1
Generated github.com/99designs/gqlgen/example/dataloader in 1.30s
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/federation/accounts/graph/prelude.resolvers.go:19:39: __TypeResolver not exported by package generated

exit status 3
federation/accounts/server.go:1: running "go": exit status 1
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/federation/products/graph/prelude.resolvers.go:19:39: __TypeResolver not exported by package generated

exit status 3
federation/products/server.go:1: running "go": exit status 1
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/federation/reviews/graph/prelude.resolvers.go:19:39: __TypeResolver not exported by package generated

exit status 3
federation/reviews/server.go:1: running "go": exit status 1
Generated github.com/99designs/gqlgen/example/fileupload in 1.14s
Generated github.com/99designs/gqlgen/example/scalars in 1.19s
Generated github.com/99designs/gqlgen/example/selection in 1.18s
Generated github.com/99designs/gqlgen/example/starwars/generated in 1.38s
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/todo/todo.go:31:14: cannot use &(resolvers literal) (value of type *resolvers) as ResolverRoot value in struct literal: missing method __Type

exit status 3
todo/todo.go:1: running "go": exit status 1
validation failed: packages.Load: /Users/steve/Documents/git/gqlgen/example/type-system-extension/resolver.go:11:9: cannot use &(resolver literal) (value of type *resolver) as ResolverRoot value in return statement: missing method __Type

exit status 3
type-system-extension/resolver.go:1: running "go": exit status 1

@StevenACoffman StevenACoffman marked this pull request as ready for review January 26, 2022 21:05
@StevenACoffman StevenACoffman merged commit 25c2cdc into master Jan 26, 2022
@StevenACoffman StevenACoffman deleted the update_parser branch January 26, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with @deprecated directive in input fields

2 participants