Fix #1636 by updating gqlparser#1857
Merged
Merged
Conversation
68c7c4b to
6604cfa
Compare
Collaborator
Author
|
Something weird is going on. I get problems for every gqlparser version down to v2.2.0: |
Collaborator
Author
|
It looks like the vektah/gqlparser#168 PR by @wilhelmeek causes a problem. Hopefully he can make another run at that work in a later PR as I'm going to revert it. |
Signed-off-by: Steve Coffman <steve@khanacademy.org>
33be2df to
0ec978a
Compare
Collaborator
Author
|
So I needed to revert the vektah/gqlparser#168 PR by @wilhelmeek and cut a v2.3.1 over there as it caused problems here and in genqlient. Upgrading the gqlparser to v2.3.0 causes these problems: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1636 and updates to gqlparser v2.3.1
Signed-off-by: Steve Coffman steve@khanacademy.org