refactor: replace boost::ends_with with absl::EndsWith#4107
Open
isotauon wants to merge 1 commit into4paradigm:mainfrom
Open
refactor: replace boost::ends_with with absl::EndsWith#4107isotauon wants to merge 1 commit into4paradigm:mainfrom
isotauon wants to merge 1 commit into4paradigm:mainfrom
Conversation
Drop the boost/algorithm/string/predicate.hpp dependency from data_collector.cc and file_sender.cc and use absl::EndsWith, matching the convention already used in src/storage/disk_table_snapshot.cc and src/storage/aggregator.cc. No behavior change.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4107 +/- ##
============================================
+ Coverage 75.31% 75.33% +0.01%
Complexity 711 711
============================================
Files 763 763
Lines 143738 143738
Branches 2074 1536 -538
============================================
+ Hits 108260 108287 +27
+ Misses 35175 35148 -27
Partials 303 303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
SDK Test Report102 files ±0 102 suites ±0 2m 12s ⏱️ -1s Results for commit 34d2e94. ± Comparison against base commit f3c48e0. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the boost-removal effort (see #4099, #4097, #4095). Replaces
boost::ends_withwithabsl::EndsWithin two files and drops the now-unusedboost/algorithm/string/predicate.hppinclude from each.src/datacollector/data_collector.ccsrc/tablet/file_sender.ccabsl::EndsWithis already the established convention in this codebase (e.g.src/storage/disk_table_snapshot.cc:53,src/storage/aggregator.cc:1306,src/sdk/sql_cluster_router.cc:4506).No behavior change — both APIs take
string_viewand returnbool.Test plan
boost::ends_withreferences in the two touched files.