Make replay a service in preparation for consolidating with search & scrollback#554
Make replay a service in preparation for consolidating with search & scrollback#554hloeung wants to merge 17 commits into
Conversation
b9de1aa to
fec77d7
Compare
fec77d7 to
53ce647
Compare
|
Merging this created an unexpected problem for me: I cannot join private channels any more |
Is it because of this change or stock 0.28.0 per #578? |
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
Pull request overview
This PR refactors the existing “replay unseen messages” logic by moving it out of userbridge.go into service.go as a first-class service command (REPLAY), aligning it structurally with search and scrollback in preparation for future consolidation work.
Changes:
- Moved the replay implementation into
mm-go-irckit/service.goand registered it as thereplayservice command. - Simplified
addUserToChannelWorkerby delegating replay behavior to the new service handler. - Adjusted channel syncing behavior so non-DM channels are synced explicitly in the worker before replay.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| mm-go-irckit/userbridge.go | Replaces the inline replay logic in the channel-join worker with a call into the new replay service handler and adjusts when syncChannel is invoked. |
| mm-go-irckit/service.go | Introduces a new replay service command by transplanting the previous replay logic into the service command layer and wiring it into the command map. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7d99d30 to
fb0308a
Compare
Move the replay code as is with minimal changes making it a service similar to
search&scrollback.This is in preparation for cleaning up and consolidating the code between the three to reduce duplicate code and so they're consistent. See also #553 for work on making search consistent.