🚧 🧹 Remove fancybox#4214
Draft
josemigallas wants to merge 2 commits into
Draft
Conversation
|
This PR is stale because it has not received activity for more than 30 days. Remove stale label or comment or this will be closed in 15 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THREESCALE-12237: Clean up fancybox
According to production logs there are no request to any fancybox file (or it returns 404).
Fancybox was replaced by Colorbox a while ago but it was left for backwards compatibility reasons. This happends on 2011, 15 years ago.
I think it's safe to remove it altogether. Claude agrees. There is a tiny possibility some very old developer portal still depends on this... I this possibility is negligible and we should stop hosting fancybox and all its assets.