Issue 7529 - Fix WebUI local policy availability test#7609
Open
droideck wants to merge 1 commit into
Open
Conversation
Description: Update the local password policy WebUI test to match the current table and modal workflow. Check empty and populated table states, open the Create New Local Policy modal, and verify the edit action only when editable policies are present. Fixes: 389ds#7529 Reviewed by: ?
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- You call
no_policies.count()andunknown_policy_type.count()multiple times; consider storing these counts in local variables to avoid repeated DOM queries and potential inconsistencies during dynamic updates. - The
get_by_text('No Local Policies')andget_by_text('Unknown policy type')locators are global and might match elements outside the local policy table; scoping these topwp_table(e.g.,pwp_table.get_by_text(...)) would make the test more robust to unrelated UI changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You call `no_policies.count()` and `unknown_policy_type.count()` multiple times; consider storing these counts in local variables to avoid repeated DOM queries and potential inconsistencies during dynamic updates.
- The `get_by_text('No Local Policies')` and `get_by_text('Unknown policy type')` locators are global and might match elements outside the local policy table; scoping these to `pwp_table` (e.g., `pwp_table.get_by_text(...)`) would make the test more robust to unrelated UI changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Update the local password policy WebUI test to match the current table and modal workflow. Check empty and populated table states, open the Create New Local Policy modal, and verify the edit action only when editable policies are present.
Fixes: #7529
Reviewed by: ?
Summary by Sourcery
Update the WebUI local password policy availability test to reflect the current table layout and modal-based create/edit workflow.
Tests: