Skip to content

Issue 7529 - Fix WebUI local policy availability test#7609

Open
droideck wants to merge 1 commit into
389ds:mainfrom
droideck:fix-webui-policy-test
Open

Issue 7529 - Fix WebUI local policy availability test#7609
droideck wants to merge 1 commit into
389ds:mainfrom
droideck:fix-webui-policy-test

Conversation

@droideck

@droideck droideck commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description: Update the local password policy WebUI test to match the current table and modal workflow. Check empty and populated table states, open the Create New Local Policy modal, and verify the edit action only when editable policies are present.

Fixes: #7529

Reviewed by: ?

Summary by Sourcery

Update the WebUI local password policy availability test to reflect the current table layout and modal-based create/edit workflow.

Tests:

  • Adjust the local password policy WebUI test to validate empty vs populated table states and updated table columns.
  • Extend the test to cover the Create New Local Policy modal and conditional edit-policy row action behavior.

Description: Update the local password policy WebUI test to match the
current table and modal workflow. Check empty and populated table states,
open the Create New Local Policy modal, and verify the edit action only
when editable policies are present.

Fixes: 389ds#7529

Reviewed by: ?

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • You call no_policies.count() and unknown_policy_type.count() multiple times; consider storing these counts in local variables to avoid repeated DOM queries and potential inconsistencies during dynamic updates.
  • The get_by_text('No Local Policies') and get_by_text('Unknown policy type') locators are global and might match elements outside the local policy table; scoping these to pwp_table (e.g., pwp_table.get_by_text(...)) would make the test more robust to unrelated UI changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- You call `no_policies.count()` and `unknown_policy_type.count()` multiple times; consider storing these counts in local variables to avoid repeated DOM queries and potential inconsistencies during dynamic updates.
- The `get_by_text('No Local Policies')` and `get_by_text('Unknown policy type')` locators are global and might match elements outside the local policy table; scoping these to `pwp_table` (e.g., `pwp_table.get_by_text(...)`) would make the test more robust to unrelated UI changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/389ds-389-ds-base-7609
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI - Debug webui suite timeout and UI failure cascade

1 participant