Issue 7595 - Reduce Actions queue saturation#7596
Open
droideck wants to merge 1 commit into
Open
Conversation
Description: Test and LMDB Test each generate large pytest matrices, which can submit hundreds of GitHub-hosted runner jobs when multiple PRs, branches, schedules, or Renovate updates trigger CI together. Limit both pytest matrix workflows with strategy.max-parallel so each workflow run releases test jobs in smaller batches while preserving full matrix coverage. Also fix the GCC Strict compile matrix name and ignore cache/hidden suite directories when generating the pytest matrix. Related: 389ds#7595 Reviewed by: ?
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/scripts/generate_matrix.py" line_range="6-15" />
<code_context>
+SUITES_PATH = "dirsrvtests/tests/suites"
</code_context>
<issue_to_address>
**issue (bug_risk):** Path replacement with SUITES_PATH risks incorrect behavior on Windows due to mixed separators.
With the previous hardcoded pattern, both `glob.glob('dirsrvtests/tests/suites/replication/*_test.py')` and `replace('dirsrvtests/tests/suites/', '')` used forward slashes, so the replacement worked even on Windows. Now `SUITES_PATH` is built with `os.path.join`, which will use `os.sep` (e.g. `\` on Windows), but `replace(f'{SUITES_PATH}/', '')` still assumes a trailing `/`, so the replacement likely never matches and the full path leaks into the suite name. To keep it portable, derive the suite name with something like `os.path.relpath(repl_test, SUITES_PATH)` or by splitting on `os.sep` instead of using `replace` on the raw string.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Test and LMDB Test each generate large pytest matrices, which can submit hundreds of GitHub-hosted runner jobs when multiple PRs, branches, schedules, or Renovate updates trigger CI together.
Limit both pytest matrix workflows with strategy.max-parallel so each workflow run releases test jobs in smaller batches while preserving full matrix coverage. Also fix the GCC Strict compile matrix name and ignore cache/hidden suite directories when generating the pytest matrix.
Related: #7595
Reviewed by: ?
Summary by Sourcery
Limit CI test matrix concurrency and tighten matrix generation to avoid invalid suites and hidden directories.
Enhancements:
CI: