Skip to content

Issue 7595 - Reduce Actions queue saturation#7596

Open
droideck wants to merge 1 commit into
389ds:mainfrom
droideck:i7595
Open

Issue 7595 - Reduce Actions queue saturation#7596
droideck wants to merge 1 commit into
389ds:mainfrom
droideck:i7595

Conversation

@droideck

@droideck droideck commented Jun 19, 2026

Copy link
Copy Markdown
Member

Description: Test and LMDB Test each generate large pytest matrices, which can submit hundreds of GitHub-hosted runner jobs when multiple PRs, branches, schedules, or Renovate updates trigger CI together.

Limit both pytest matrix workflows with strategy.max-parallel so each workflow run releases test jobs in smaller batches while preserving full matrix coverage. Also fix the GCC Strict compile matrix name and ignore cache/hidden suite directories when generating the pytest matrix.

Related: #7595

Reviewed by: ?

Summary by Sourcery

Limit CI test matrix concurrency and tighten matrix generation to avoid invalid suites and hidden directories.

Enhancements:

  • Refine pytest matrix generation to ignore hidden, cache, and symlinked suite entries while handling replication tests via a shared suites path constant.
  • Standardize the GCC Strict compile job name in the compile workflow.

CI:

  • Set max-parallel to 6 for both pytest and LMDB pytest matrix workflows to throttle concurrent GitHub-hosted jobs.

Description: Test and LMDB Test each generate large pytest matrices,
which can submit hundreds of GitHub-hosted runner jobs when multiple
PRs, branches, schedules, or Renovate updates trigger CI together.

Limit both pytest matrix workflows with strategy.max-parallel so each
workflow run releases test jobs in smaller batches while preserving full
matrix coverage. Also fix the GCC Strict compile matrix name and ignore
cache/hidden suite directories when generating the pytest matrix.

Related: 389ds#7595

Reviewed by: ?

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".github/scripts/generate_matrix.py" line_range="6-15" />
<code_context>
+SUITES_PATH = "dirsrvtests/tests/suites"
</code_context>
<issue_to_address>
**issue (bug_risk):** Path replacement with SUITES_PATH risks incorrect behavior on Windows due to mixed separators.

With the previous hardcoded pattern, both `glob.glob('dirsrvtests/tests/suites/replication/*_test.py')` and `replace('dirsrvtests/tests/suites/', '')` used forward slashes, so the replacement worked even on Windows. Now `SUITES_PATH` is built with `os.path.join`, which will use `os.sep` (e.g. `\` on Windows), but `replace(f'{SUITES_PATH}/', '')` still assumes a trailing `/`, so the replacement likely never matches and the full path leaks into the suite name. To keep it portable, derive the suite name with something like `os.path.relpath(repl_test, SUITES_PATH)` or by splitting on `os.sep` instead of using `replace` on the raw string.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread .github/scripts/generate_matrix.py
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/389ds-389-ds-base-7596
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant