Skip to content

Issue 7400 - 389-ds handles " *" as "*" in ldapsearch command and ign…#7401

Open
tbordaz wants to merge 1 commit into
389ds:mainfrom
tbordaz:issue_7400
Open

Issue 7400 - 389-ds handles " *" as "*" in ldapsearch command and ign…#7401
tbordaz wants to merge 1 commit into
389ds:mainfrom
tbordaz:issue_7400

Conversation

@tbordaz

@tbordaz tbordaz commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

…ores space character

Bug description:
A initial substring search containing trailing spaces may return
improper matching entries.
The RC is that the normalization of values trim leading and trailing
spaces.

Fix description:
When trimming (spaces) is requested the caller should specify if
leading/trailing/both spaces should be trimmed

fixes: #7400

Reviewed by:

Summary by Sourcery

Make whitespace normalization configurable so callers can control trimming of leading and trailing blanks.

Bug Fixes:

  • Prevent substring and value comparisons from incorrectly removing trailing spaces that affect LDAP search matching.

Enhancements:

  • Introduce trim mask flags for leading and trailing blanks and propagate them through string and value normalization helpers to support finer-grained control.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tbordaz tbordaz added the work in progress Work in Progress - can be reviewed, but not ready for merge. label Apr 10, 2026
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/389ds-389-ds-base-7401
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@tbordaz tbordaz removed the work in progress Work in Progress - can be reviewed, but not ready for merge. label May 27, 2026
…ores space character

Bug description:
	A initial substring search containing trailing spaces may return
	improper matching entries.
	The RC is that the normalization of values trim leading and trailing
	spaces.

Fix description:
	When trimming (spaces) is requested the caller should specify if
	leading/trailing/both spaces should be trimmed

fixes: 389ds#7400

Assisted by: Cursor

Reviewed by:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

389-ds handles " *" as "*" in ldapsearch command and ignores space character

1 participant