fix: add asset_id validation to FungibleAssetDelta::validate#3138
Open
Sertug17 wants to merge 2 commits into
Open
fix: add asset_id validation to FungibleAssetDelta::validate#3138Sertug17 wants to merge 2 commits into
Sertug17 wants to merge 2 commits into
Conversation
The expect() on missing init_map entry could panic if a map slot entry was added to the patch without a corresponding tracked key. Changed to gracefully skip unrecognized keys via let-else. Closes 0xMiden#3132
The validate() function checked that vault keys have fungible composition but didn't verify that the asset_id component is empty. Per AssetVaultKey semantics, fungible assets must have a zero asset ID. A crafted key with a non-zero asset ID would pass validation but produce a different SMT key, potentially corrupting vault state on delta application. Closes 0xMiden#3134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validate()function checked that vault keys have fungible composition but didn't verify that theasset_idcomponent is empty. PerAssetVaultKeysemantics, fungible assets must have a zero asset ID. A crafted key with a non-zero asset ID would pass validation but produce a different SMT key, potentially corrupting vault state on delta application.Closes #3134