feat: migrate standards to miden-project#3107
Open
TomasArrachea wants to merge 7 commits into
Open
Conversation
Comment on lines
74
to
78
| fn compile_standards_lib( | ||
| source_dir: &Path, | ||
| target_dir: &Path, | ||
| assembler: Assembler, | ||
| ) -> Result<Library> { |
Contributor
There was a problem hiding this comment.
The assembler we pass here is TransactionKernel::assembler which includes the CoreLibrary and ProtocolLib, but could we also set this up to express those dependencies at the miden-project level? I think this would be the better long-term structure, but not sure if it makes sense to do in this PR or another one.
TomasArrachea
force-pushed
the
tomasarrachea-standards-miden-project
branch
from
7c3eda0 to
0dec2a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds towards #2896.
Add a project for the standards library at
crates/miden-standards/asm/standards/miden-project.toml, and one project per account component. The kernel/protocol/standards libs are linked on the assembler, and so each component project has no deps. No workspace is needed.