Skip to content

Commit 350a8a2

Browse files
test: fix test_append_adds_examples to reflect Phoenix versioning semantics
1 parent 7b001ed commit 350a8a2

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
strategy:
7070
fail-fast: false
7171
matrix:
72-
phoenix-major: [13, 14]
72+
phoenix-major: [13, 14, 15]
7373

7474
steps:
7575
- uses: actions/checkout@v6

tests/integration/test_uploader_integration.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,14 @@ def test_append_adds_examples(self, phoenix_client, tmp_path: Path):
8080
DatasetUploader(csv_path=csv_2, phoenix_client=phoenix_client).upload(
8181
on_exist="skip"
8282
)
83+
count_before = len(phoenix_client.datasets.get_dataset(dataset=tag))
8384

8485
DatasetUploader(csv_path=csv_3, phoenix_client=phoenix_client).upload(
8586
on_exist="append"
8687
)
87-
88-
# Phoenix creates a new version per upload; get_dataset returns the
89-
# latest version which contains only the 3 newly appended examples.
9088
count_after = len(phoenix_client.datasets.get_dataset(dataset=tag))
91-
assert count_after == 3
89+
90+
assert count_after == count_before + 3
9291

9392
def test_custom_keys(self, phoenix_client, tmp_path: Path):
9493
import uuid

0 commit comments

Comments
 (0)