From e463c47ed358fcbf80059fa56c6a35e97a49f7a8 Mon Sep 17 00:00:00 2001 From: "shane.xb.qian" Date: Tue, 19 Sep 2023 23:02:30 +0800 Subject: [PATCH 1/2] fix: move additionalTextEdits switch Signed-off-by: shane.xb.qian --- autoload/lsp/completion.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autoload/lsp/completion.vim b/autoload/lsp/completion.vim index 1fa85e2c..2495a922 100644 --- a/autoload/lsp/completion.vim +++ b/autoload/lsp/completion.vim @@ -582,7 +582,6 @@ def LspCompleteDone(bnr: number) var completionData: any = v:completed_item->get('user_data', '') if completionData->type() != v:t_dict - || !opt.lspOptions.completionTextEdit return endif @@ -593,6 +592,7 @@ def LspCompleteDone(bnr: number) completionData = lspserver.resolveCompletion(completionData, true) endif if !completionData->get('additionalTextEdits', {})->empty() + \ && opt.lspOptions.completionTextEdit textedit.ApplyTextEdits(bnr, completionData.additionalTextEdits) endif From a07a5507ba885227007cb54c3375ba23062bff38 Mon Sep 17 00:00:00 2001 From: "shane.xb.qian" Date: Tue, 19 Dec 2023 14:59:21 +0800 Subject: [PATCH 2/2] none: check 'completionTextEdit' when non 'additionalTextEdits' as well Signed-off-by: shane.xb.qian --- autoload/lsp/completion.vim | 1 + 1 file changed, 1 insertion(+) diff --git a/autoload/lsp/completion.vim b/autoload/lsp/completion.vim index 2495a922..007cded4 100644 --- a/autoload/lsp/completion.vim +++ b/autoload/lsp/completion.vim @@ -586,6 +586,7 @@ def LspCompleteDone(bnr: number) endif if !completionData->has_key('additionalTextEdits') + \ && opt.lspOptions.completionTextEdit # Some language servers (e.g. typescript) delay the computation of the # additional text edits. So try to resolve the completion item now to get # the text edits.