Fix %-encoding in UriToFilePath

In #1119 a change was made to "unquote" the URI before converting to a
file path, ostensibly to support windows. It seems that either that
change was broken, or that Python standard library has since been fixed
and this has caused legitimate %-encoded paths (like foo#bar/test.c) to
now truncate at the #.

The tests added for UriToFilePath with Windows paths still pass
unchanged without the hack on Python 3.14 so I'm happy to just remove
the hack.

Author: puremourning

ycmd/completers/language_server/language_server_protocol.py

@@ -19,7 +19,7 @@
 import os
 import json
 import hashlib
-from urllib.parse import urljoin, urlparse, unquote
+from urllib.parse import urljoin, urlparse
 from urllib.request import pathname2url, url2pathname
 
 from ycmd.utils import ( ByteOffsetToCodepointOffset,
@@ -767,8 +767,7 @@ def UriToFilePath( uri ):
   # whereas
   # url2pathname('/C:/') == 'C:\\'
   # Therefore first unquote pathname.
-  pathname = unquote( parsed_uri.path )
-  return os.path.abspath( url2pathname( pathname ) )
+  return os.path.abspath( url2pathname( uri, require_scheme=True ) )
 
 
 def _BuildMessageData( message ):

ycmd/tests/language_server/language_server_protocol_test.py

@@ -153,6 +153,8 @@ def test_UriToFilePath_Unix( self ):
                  equal_to( '/usr/local/test/test.test' ) )
     assert_that( lsp.UriToFilePath( 'file:///usr/local/test/test.test' ),
                  equal_to( '/usr/local/test/test.test' ) )
+    assert_that( lsp.UriToFilePath( 'file:///usr/local/test%23foo/test.test' ),
+                 equal_to( '/usr/local/test#foo/test.test' ) )
 
 
   @WindowsOnly