fix: apply heuristic checks for clickable elements (#38)

Author: mtraworld

configs/default-config.toml

@@ -39,12 +39,24 @@ accessibility_check_on_start = true
 # Users can add or remove roles as needed
 clickable_roles = [
     "AXButton",
+    "AXComboBox",
     "AXCheckBox",
     "AXRadioButton",
-    "AXPopUpButton",
     "AXLink",
+    "AXPopUpButton",
     "AXTextField",
+    "AXSlider",
+    "AXTabGroup",
+    "AXTabButton",
+    "AXSwitch",
+    "AXToolbar",
+    "AXDisclosureTriangle",
     "AXTextArea",
+    "AXMenuButton",
+    "AXMenuItem",
+    "AXGroup",
+    "AXImage",
+    "AXCell",
 ]
 
 # Global accessibility roles that are treated as scrollable

internal/accessibility/element.go

@@ -380,19 +380,11 @@ func (e *Element) IsClickable() bool {
 		return false
 	}
 
-	// Some elements (like Dock items, menu bar items) may not report as "enabled"
-	// but are still clickable
-	exemptRoles := map[string]bool{
-		"AXDockItem":    true,
-		"AXMenuBarItem": true,
-	}
+	// We are checking this with some predefined heuristics
+	// Not sure if its working fine, but it works for now
+	result := C.hasClickAction(e.ref)
 
-	if exemptRoles[info.Role] {
-		return true
-	}
-
-	// For other roles, check if enabled
-	return info.IsEnabled
+	return result == 1
 }
 
 // GetAllWindows returns all windows of the focused application

internal/bridge/accessibility.m

@@ -496,31 +496,112 @@ int getChildrenCount(void* element) {
     return result;
 }
 
+static CFStringRef kAXLinkRole            = CFSTR("AXLink");
+static CFStringRef kAXCheckboxRole        = CFSTR("AXCheckBox");
+static CFStringRef kAXFocusableAttribute  = CFSTR("AXFocusable");
+static CFStringRef kAXVisibleAttribute    = CFSTR("AXVisible");
+
 // Check if element has click action
 int hasClickAction(void* element) {
     if (!element) return 0;
-
     AXUIElementRef axElement = (AXUIElementRef)element;
+
+    // Check explicit actions
     CFArrayRef actions = NULL;
+    if (AXUIElementCopyActionNames(axElement, &actions) == kAXErrorSuccess && actions) {
+        CFIndex count = CFArrayGetCount(actions);
+        for (CFIndex i = 0; i < count; i++) {
+            CFStringRef action = (CFStringRef)CFArrayGetValueAtIndex(actions, i);
+            if (CFStringCompare(action, kAXPressAction, 0) == kCFCompareEqualTo ||
+                CFStringCompare(action, CFSTR("AXConfirm"), 0) == kCFCompareEqualTo ||
+                CFStringCompare(action, CFSTR("AXPick"), 0) == kCFCompareEqualTo ||
+                CFStringCompare(action, CFSTR("AXShowMenu"), 0) == kCFCompareEqualTo) {
+                CFRelease(actions);
+                return 1;
+            }
+        }
+        CFRelease(actions);
+    }
+
+    // Focusable + enabled
+    CFBooleanRef enabled = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXEnabledAttribute, (CFTypeRef *)&enabled) == kAXErrorSuccess && enabled) {
+        if (CFBooleanGetValue(enabled)) {
+            CFRelease(enabled);
+            CFBooleanRef focusable = NULL;
+            if (AXUIElementCopyAttributeValue(axElement, kAXFocusableAttribute, (CFTypeRef *)&focusable) == kAXErrorSuccess && focusable) {
+                int isFocus = CFBooleanGetValue(focusable);
+                CFRelease(focusable);
+                if (isFocus) return 1;
+            }
+        } else CFRelease(enabled);
+    }
 
-    AXError error = AXUIElementCopyActionNames(axElement, &actions);
-    if (error != kAXErrorSuccess || !actions) {
-        return 0;
+    // Has title or label
+    CFTypeRef title = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXTitleAttribute, &title) == kAXErrorSuccess && title) {
+        CFRelease(title);
+        return 1;
+    }
+
+    // Has description or help
+    CFTypeRef desc = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXDescriptionAttribute, &desc) == kAXErrorSuccess && desc) {
+        CFRelease(desc);
+        return 1;
+    }
+
+    // Has value or selected state
+    CFTypeRef value = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXValueAttribute, &value) == kAXErrorSuccess && value) {
+        CFRelease(value);
+        return 1;
+    }
+
+    CFTypeRef selected = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXSelectedAttribute, &selected) == kAXErrorSuccess && selected) {
+        CFRelease(selected);
+        return 1;
+    }
+
+    // Has visual bounds
+    CFTypeRef position = NULL;
+    CFTypeRef size = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXPositionAttribute, &position) == kAXErrorSuccess &&
+        AXUIElementCopyAttributeValue(axElement, kAXSizeAttribute, &size) == kAXErrorSuccess &&
+        position && size) {
+        CFRelease(position);
+        CFRelease(size);
+        return 1;
     }
+    if (position) CFRelease(position);
+    if (size) CFRelease(size);
 
-    CFIndex count = CFArrayGetCount(actions);
-    int hasPress = 0;
+    // Expanded/collapsible state
+    CFTypeRef expanded = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXExpandedAttribute, &expanded) == kAXErrorSuccess && expanded) {
+        CFRelease(expanded);
+        return 1;
+    }
 
-    for (CFIndex i = 0; i < count; i++) {
-        CFStringRef action = (CFStringRef)CFArrayGetValueAtIndex(actions, i);
-        if (CFStringCompare(action, kAXPressAction, 0) == kCFCompareEqualTo) {
-            hasPress = 1;
-            break;
+    // Visible + leaf node
+    CFBooleanRef visible = NULL;
+    if (AXUIElementCopyAttributeValue(axElement, kAXVisibleAttribute, (CFTypeRef *)&visible) == kAXErrorSuccess && visible) {
+        if (CFBooleanGetValue(visible)) {
+            CFArrayRef children = NULL;
+            if (AXUIElementCopyAttributeValue(axElement, kAXChildrenAttribute, (CFTypeRef *)&children) == kAXErrorSuccess) {
+                if (children && CFArrayGetCount(children) == 0) {
+                    CFRelease(children);
+                    CFRelease(visible);
+                    return 1;
+                }
+                if (children) CFRelease(children);
+            }
         }
+        CFRelease(visible);
     }
 
-    CFRelease(actions);
-    return hasPress;
+    return 0;
 }
 
 // Perform click

internal/config/config.go

@@ -109,16 +109,24 @@ func DefaultConfig() *Config {
 			AccessibilityCheckOnStart: true,
 			ClickableRoles: []string{
 				"AXButton",
+				"AXComboBox",
 				"AXCheckBox",
 				"AXRadioButton",
-				"AXPopUpButton",
-				"AXMenuItem",
-				"AXMenuBarItem",
-				"AXDockItem",
-				"AXApplicationDockItem",
 				"AXLink",
+				"AXPopUpButton",
 				"AXTextField",
+				"AXSlider",
+				"AXTabGroup",
+				"AXTabButton",
+				"AXSwitch",
+				"AXToolbar",
+				"AXDisclosureTriangle",
 				"AXTextArea",
+				"AXMenuButton",
+				"AXMenuItem",
+				"AXGroup",
+				"AXImage",
+				"AXCell",
 			},
 			ScrollableRoles: []string{
 				"AXScrollArea",
@@ -409,7 +417,6 @@ func (c *Config) GetClickableRolesForApp(bundleID string) []string {
 	// Add menubar roles if enabled
 	if c.General.IncludeMenubarHints {
 		rolesMap["AXMenuBarItem"] = struct{}{}
-		rolesMap["AXMenuItem"] = struct{}{}
 	}
 
 	// Add dock roles if enabled