fix: remove numeric hint, feels useless (#24)

Author: y3owk1n

README.md

@@ -223,7 +223,6 @@ or any other location specified via the `--config` flag.
 ```toml
 [general]
 hint_characters = "asdfghjkl"  # Characters used for hints
-hint_style = "alphabet"        # "alphabet" or "numeric"
 
 [accessibility]
 # Clickable elements

cmd/govim/main.go

@@ -92,7 +92,6 @@ func NewApp(cfg *config.Config) (*App, error) {
 	// Create hint generator
 	hintGen := hints.NewGenerator(
 		cfg.General.HintCharacters,
-		cfg.General.HintStyle,
 		cfg.Performance.MaxHintsDisplayed,
 	)
 

configs/default-config.toml

@@ -9,18 +9,11 @@
 # - Colors: `#RGB`, `#RRGGBB`, or `#RRGGBBAA`.
 # - Hotkeys: `Modifier+...+Key` with modifiers `Cmd`, `Ctrl`, `Alt`, `Shift`, `Option`.
 #   Examples: `Cmd+Shift+Space`, `Ctrl+D`. Set to "" to disable.
-# - When `hint_style = "numeric"`, `hint_characters` are ignored.
-
 [general]
 # Characters used to build hint labels for alphabet style.
 # - At least 2 characters; choose distinct, easy-to-type ones.
 hint_characters = "asdfghjkl"
 
-# Hint label style: "alphabet" or "numeric".
-# - "alphabet": uses `hint_characters` to build AA/AS/...
-# - "numeric": labels are numbers 1..N; ignores `hint_characters`.
-hint_style = "alphabet"
-
 # Check Accessibility permission on startup; exits with guidance if missing.
 accessibility_check_on_start = true
 

internal/config/config.go

@@ -23,7 +23,6 @@ type Config struct {
 
 type GeneralConfig struct {
 	HintCharacters            string `toml:"hint_characters"`
-	HintStyle                 string `toml:"hint_style"`
 	AccessibilityCheckOnStart bool   `toml:"accessibility_check_on_start"`
 }
 
@@ -102,7 +101,6 @@ func DefaultConfig() *Config {
 	return &Config{
 		General: GeneralConfig{
 			HintCharacters:            "asdfghjkl",
-			HintStyle:                 "alphabet",
 			AccessibilityCheckOnStart: true,
 		},
 		Accessibility: AccessibilityConfig{
@@ -239,16 +237,11 @@ func GetConfigPath() string {
 
 // Validate validates the configuration
 func (c *Config) Validate() error {
-	// Validate hint style
-	if c.General.HintStyle != "alphabet" && c.General.HintStyle != "numeric" {
-		return fmt.Errorf("hint_style must be 'alphabet' or 'numeric'")
-	}
-
 	// Validate hint characters
 	if strings.TrimSpace(c.General.HintCharacters) == "" {
 		return fmt.Errorf("hint_characters cannot be empty")
 	}
-	if c.General.HintStyle == "alphabet" && len(c.General.HintCharacters) < 2 {
+	if len(c.General.HintCharacters) < 2 {
 		return fmt.Errorf("hint_characters must contain at least 2 characters")
 	}
 

internal/config/config_test.go

@@ -13,10 +13,6 @@ func TestDefaultConfig(t *testing.T) {
 		t.Errorf("Expected hint_characters to be 'asdfghjkl', got '%s'", cfg.General.HintCharacters)
 	}
 
-	if cfg.General.HintStyle != "alphabet" {
-		t.Errorf("Expected hint_style to be 'alphabet', got '%s'", cfg.General.HintStyle)
-	}
-
 	if cfg.Logging.LogLevel != "info" {
 		t.Errorf("Expected log_level to be 'info', got '%s'", cfg.Logging.LogLevel)
 	}
@@ -33,13 +29,6 @@ func TestValidate(t *testing.T) {
 			modify:  func(c *Config) {},
 			wantErr: false,
 		},
-		{
-			name: "invalid hint style",
-			modify: func(c *Config) {
-				c.General.HintStyle = "invalid"
-			},
-			wantErr: true,
-		},
 		{
 			name: "invalid log level",
 			modify: func(c *Config) {

internal/hints/generator.go

@@ -1,7 +1,6 @@
 package hints
 
 import (
-	"fmt"
 	"image"
 	"sort"
 	"strings"
@@ -21,19 +20,17 @@ type Hint struct {
 // Generator generates hints for UI elements
 type Generator struct {
 	characters string
-	style      string
 	maxHints   int
 }
 
 // NewGenerator creates a new hint generator
-func NewGenerator(characters, style string, maxHints int) *Generator {
+func NewGenerator(characters string, maxHints int) *Generator {
 	// Ensure we have at least some characters
 	if characters == "" {
 		characters = "asdfghjkl" // fallback to default
 	}
 	return &Generator{
 		characters: characters,
-		style:      style,
 		maxHints:   maxHints,
 	}
 }
@@ -64,13 +61,8 @@ func (g *Generator) Generate(elements []*accessibility.TreeNode) ([]*Hint, error
 		sortedElements = sortedElements[:g.maxHints]
 	}
 
-	// Generate labels
-	var labels []string
-	if g.style == "alphabet" {
-		labels = g.generateAlphabetLabels(len(sortedElements))
-	} else {
-		labels = g.generateNumericLabels(len(sortedElements))
-	}
+	// Generate labels (alphabet-only)
+	labels := g.generateAlphabetLabels(len(sortedElements))
 
 	// Generate hints
 	hints := make([]*Hint, len(sortedElements))
@@ -140,15 +132,6 @@ func (g *Generator) generateAlphabetLabels(count int) []string {
 	return labels[:count]
 }
 
-// generateNumericLabels generates numeric labels (1, 2, 3, ...)
-func (g *Generator) generateNumericLabels(count int) []string {
-	labels := make([]string, count)
-	for i := 0; i < count; i++ {
-		labels[i] = fmt.Sprintf("%d", i+1)
-	}
-	return labels
-}
-
 // FindHintByLabel finds a hint by its label
 func FindHintByLabel(hints []*Hint, label string) *Hint {
 	label = strings.ToLower(label)

internal/hints/generator_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 func TestGenerateAlphabetLabels(t *testing.T) {
-	gen := NewGenerator("asdf", "alphabet", 100)
+	gen := NewGenerator("asdf", 100)
 
 	tests := []struct {
 		count    int
@@ -38,34 +38,6 @@ func TestGenerateAlphabetLabels(t *testing.T) {
 	}
 }
 
-func TestGenerateNumericLabels(t *testing.T) {
-	gen := NewGenerator("", "numeric", 100)
-
-	tests := []struct {
-		count    int
-		expected []string
-	}{
-		{0, []string{}},
-		{1, []string{"1"}},
-		{5, []string{"1", "2", "3", "4", "5"}},
-		{10, []string{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"}},
-	}
-
-	for _, tt := range tests {
-		labels := gen.generateNumericLabels(tt.count)
-		if len(labels) != len(tt.expected) {
-			t.Errorf("Expected %d labels, got %d", len(tt.expected), len(labels))
-			continue
-		}
-
-		for i, label := range labels {
-			if label != tt.expected[i] {
-				t.Errorf("Label %d: expected %s, got %s", i, tt.expected[i], label)
-			}
-		}
-	}
-}
-
 func TestFindHintByLabel(t *testing.T) {
 	hints := []*Hint{
 		{Label: "a", Position: image.Point{X: 0, Y: 0}},
@@ -221,7 +193,6 @@ func TestGenerate(t *testing.T) {
 	tests := []struct {
 		name       string
 		characters string
-		style      string
 		maxHints   int
 		elements   []*accessibility.TreeNode
 		wantCount  int
@@ -230,25 +201,15 @@ func TestGenerate(t *testing.T) {
 		{
 			name:       "alphabet style",
 			characters: "asdf",
-			style:      "alphabet",
 			maxHints:   10,
 			elements:   elements,
 			wantCount:  3,
 			wantLabels: []string{"A", "S", "D"},
 		},
-		{
-			name:       "numeric style",
-			characters: "asdf",
-			style:      "numeric",
-			maxHints:   10,
-			elements:   elements,
-			wantCount:  3,
-			wantLabels: []string{"1", "2", "3"},
-		},
+
 		{
 			name:       "limited hints",
 			characters: "asdf",
-			style:      "alphabet",
 			maxHints:   2,
 			elements:   elements,
 			wantCount:  2,
@@ -257,7 +218,6 @@ func TestGenerate(t *testing.T) {
 		{
 			name:       "empty elements",
 			characters: "asdf",
-			style:      "alphabet",
 			maxHints:   10,
 			elements:   []*accessibility.TreeNode{},
 			wantCount:  0,
@@ -267,7 +227,7 @@ func TestGenerate(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			generator := NewGenerator(tt.characters, tt.style, tt.maxHints)
+			generator := NewGenerator(tt.characters, tt.maxHints)
 			hints, err := generator.Generate(tt.elements)
 
 			if err != nil {
@@ -343,7 +303,7 @@ func createMockElement(x, y int) *accessibility.TreeNode {
 }
 
 func TestGenerateHints(t *testing.T) {
-	gen := NewGenerator("asdf", "alphabet", 100)
+	gen := NewGenerator("asdf", 100)
 
 	elements := []*accessibility.TreeNode{
 		createMockElement(10, 10),
@@ -412,7 +372,7 @@ func TestGenerateHints_EdgeCases(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			gen := NewGenerator("asdf", "alphabet", tt.maxHints)
+			gen := NewGenerator("asdf", tt.maxHints)
 			hints, err := gen.Generate(tt.elements)
 
 			if tt.expectError {
@@ -445,7 +405,7 @@ func TestGenerateHints_EdgeCases(t *testing.T) {
 }
 
 func TestGenerateHintsWithMaxLimit(t *testing.T) {
-	gen := NewGenerator("asdf", "alphabet", 2)
+	gen := NewGenerator("asdf", 2)
 
 	elements := []*accessibility.TreeNode{
 		createMockElement(10, 10),
@@ -480,7 +440,7 @@ func TestGenerateAlphabetLabels_EdgeCases(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			gen := NewGenerator(tt.chars, "alphabet", 1000)
+			gen := NewGenerator(tt.chars, 1000)
 			labels := gen.generateAlphabetLabels(tt.count)
 
 			if tt.count <= 0 {
@@ -535,7 +495,7 @@ func TestNoPrefixConflicts(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			gen := NewGenerator(tt.chars, "alphabet", 1000)
+			gen := NewGenerator(tt.chars, 1000)
 			labels := gen.generateAlphabetLabels(tt.count)
 
 			if len(labels) != tt.count {