fix: make action hints style configurable to be visually difference (#22)

Author: y3owk1n

cmd/govim/main.go

@@ -348,9 +348,23 @@ func (a *App) activateHintMode(withActions bool) {
 	a.currentHints = hints.NewHintCollection(hintList)
 
 	// Draw hints
-	if err := a.hintOverlay.DrawHints(hintList); err != nil {
-		a.logger.Error("Failed to draw hints", zap.Error(err))
-		return
+	// Use distinct colors when entering hint mode with actions
+	if withActions {
+		style := a.config.Hints
+		style.BackgroundColor = a.config.Hints.ActionBackgroundColor
+		style.TextColor = a.config.Hints.ActionTextColor
+		style.MatchedTextColor = a.config.Hints.ActionMatchedTextColor
+		style.BorderColor = a.config.Hints.ActionBorderColor
+		style.Opacity = a.config.Hints.ActionOpacity
+		if err := a.hintOverlay.DrawHintsWithStyle(hintList, style); err != nil {
+			a.logger.Error("Failed to draw hints", zap.Error(err))
+			return
+		}
+	} else {
+		if err := a.hintOverlay.DrawHints(hintList); err != nil {
+			a.logger.Error("Failed to draw hints", zap.Error(err))
+			return
+		}
 	}
 
 	a.hintOverlay.Show()
@@ -456,8 +470,20 @@ func (a *App) handleHintKey(key string) {
 		hint.MatchedPrefix = a.hintInput
 	}
 	a.hintOverlay.Clear()
-	if err := a.hintOverlay.DrawHints(filtered); err != nil {
-		a.logger.Error("Failed to redraw hints", zap.Error(err))
+	if a.currentMode == ModeHintWithActions {
+		style := a.config.Hints
+		style.BackgroundColor = a.config.Hints.ActionBackgroundColor
+		style.TextColor = a.config.Hints.ActionTextColor
+		style.MatchedTextColor = a.config.Hints.ActionMatchedTextColor
+		style.BorderColor = a.config.Hints.ActionBorderColor
+		style.Opacity = a.config.Hints.ActionOpacity
+		if err := a.hintOverlay.DrawHintsWithStyle(filtered, style); err != nil {
+			a.logger.Error("Failed to redraw hints", zap.Error(err))
+		}
+	} else {
+		if err := a.hintOverlay.DrawHints(filtered); err != nil {
+			a.logger.Error("Failed to redraw hints", zap.Error(err))
+		}
 	}
 
 	// If exactly one match and input matches the full label
@@ -534,6 +560,13 @@ func (a *App) showActionMenu(hint *hints.Hint) {
 
 	// Create smaller style for action hints
 	actionStyle := a.config.Hints
+	// Apply distinct colors for action overlay from config
+	actionStyle.BackgroundColor = a.config.Hints.ActionBackgroundColor
+	actionStyle.TextColor = a.config.Hints.ActionTextColor
+	actionStyle.MatchedTextColor = a.config.Hints.ActionMatchedTextColor
+	actionStyle.BorderColor = a.config.Hints.ActionBorderColor
+	actionStyle.Opacity = a.config.Hints.ActionOpacity
+	// Use smaller sizing for action hints
 	actionStyle.FontSize = 11    // Smaller font
 	actionStyle.Padding = 3      // Less padding
 	actionStyle.BorderRadius = 3 // Smaller border radius

configs/default-config.toml

@@ -92,6 +92,22 @@ border_color = "#000000"
 # Opacity (0.0 to 1.0)
 opacity = 0.95
 
+# Action overlay colors (used when selecting click type)
+# Background color (hex format)
+action_background_color = "#66CCFF"
+
+# Text color (hex format)
+action_text_color = "#000000"
+
+# Matched text color (hex format)
+action_matched_text_color = "#003366"
+
+# Border color (hex format)
+action_border_color = "#000000"
+
+# Opacity (0.0 to 1.0)
+action_opacity = 0.95
+
 # Action keys for hint mode with actions (hardcoded):
 #   l = left click, r = right click, d = double click, m = middle click
 

internal/config/config.go

@@ -71,6 +71,12 @@ type HintsConfig struct {
 	Opacity          float64 `toml:"opacity"`
 	Menubar          bool    `toml:"menubar"`
 	Dock             bool    `toml:"dock"`
+	// Action overlay specific colors and opacity
+	ActionBackgroundColor  string  `toml:"action_background_color"`
+	ActionTextColor        string  `toml:"action_text_color"`
+	ActionMatchedTextColor string  `toml:"action_matched_text_color"`
+	ActionBorderColor      string  `toml:"action_border_color"`
+	ActionOpacity          float64 `toml:"action_opacity"`
 }
 
 type PerformanceConfig struct {
@@ -150,6 +156,12 @@ func DefaultConfig() *Config {
 			Opacity:          0.95,
 			Menubar:          false,
 			Dock:             false,
+			// Defaults for action overlay colors to visually differentiate
+			ActionBackgroundColor:  "#66CCFF",
+			ActionTextColor:        "#000000",
+			ActionMatchedTextColor: "#003366",
+			ActionBorderColor:      "#000000",
+			ActionOpacity:          0.95,
 		},
 		Performance: PerformanceConfig{
 			MaxHintsDisplayed:    200,
@@ -255,6 +267,9 @@ func (c *Config) Validate() error {
 	if c.Hints.Opacity < 0 || c.Hints.Opacity > 1 {
 		return fmt.Errorf("hints.opacity must be between 0 and 1")
 	}
+	if c.Hints.ActionOpacity < 0 || c.Hints.ActionOpacity > 1 {
+		return fmt.Errorf("hints.action_opacity must be between 0 and 1")
+	}
 
 	// Validate performance settings
 	if c.Performance.MaxHintsDisplayed < 1 {
@@ -288,6 +303,19 @@ func (c *Config) Validate() error {
 	if err := validateColor(c.Hints.BorderColor, "hints.border_color"); err != nil {
 		return err
 	}
+	// Validate action overlay colors
+	if err := validateColor(c.Hints.ActionBackgroundColor, "hints.action_background_color"); err != nil {
+		return err
+	}
+	if err := validateColor(c.Hints.ActionTextColor, "hints.action_text_color"); err != nil {
+		return err
+	}
+	if err := validateColor(c.Hints.ActionMatchedTextColor, "hints.action_matched_text_color"); err != nil {
+		return err
+	}
+	if err := validateColor(c.Hints.ActionBorderColor, "hints.action_border_color"); err != nil {
+		return err
+	}
 	if err := validateColor(c.Scroll.HighlightColor, "scroll.highlight_color"); err != nil {
 		return err
 	}