fix(cli): open docs on Linux (#1467)

Co-authored-by: nightcityblade <nightcityblade@gmail.com>
Co-authored-by: Kyle Wong <62775956+y3owk1n@users.noreply.github.com>
Signed-off-by: Kyle Wong <62775956+y3owk1n@users.noreply.github.com>

Author: 3 people

docs/CLI.md

@@ -99,7 +99,7 @@ Accepted by every command.
 | [`toggle-screen-share`](#neru-toggle-screen-share)           | Hide overlays while sharing     | Yes | macOS |
 | [`roles`](#neru-roles)                                       | List the role vocabulary        | No  | All |
 | [`services`](#neru-services)                                 | Manage the system service       | No  | macOS · Linux |
-| [`docs`](#neru-docs)                                         | Open documentation in a browser | No  | macOS |
+| [`docs`](#neru-docs)                                         | Open documentation in a browser | No  | macOS · Linux |
 
 ¹ Element discovery quality differs by platform: a full accessibility tree on
 macOS, an AT-SPI walk on Linux whose coverage depends on the application, and an
@@ -1546,7 +1546,7 @@ Open documentation in a browser.
 neru docs config|cli
 ```
 
-**Platforms:** macOS only; other platforms return `ERR_NOT_SUPPORTED`.
+**Platforms:** macOS and Linux; other platforms return `ERR_NOT_SUPPORTED`.
 
 URLs point at the Git tag matching the installed version. Development builds
 fall back to `main`.

docs/CROSS_PLATFORM.md

@@ -894,9 +894,7 @@ command — that means less here than it does on macOS, whether or not the
 
 **Linux**
 
-1. `neru docs` — returns `CodeNotSupported` although the tray already opens
-   URLs through `xdg-open` in the same repo
-2. Screen capture on KDE — X11 (`XGetImage`) and the wlroots family
+1. Screen capture on KDE — X11 (`XGetImage`) and the wlroots family
    (`wlr-screencopy-unstable-v1`) capture real pixels and honor a region, so
    the blessed stack is done. KWin implements no screencopy protocol Neru can
    use and reports `CodeNotSupported` naming itself. Its only pixel source is

internal/app/components/systray/open_linux.go

@@ -0,0 +1,14 @@
+//go:build linux
+
+package systray
+
+import (
+	"context"
+	"os/exec"
+)
+
+// Opens a URL or file path with the Linux desktop's default handler.
+// Does not validate the target or wait for the launched app.
+func openExternal(ctx context.Context, target string) error {
+	return exec.CommandContext(ctx, "xdg-open", target).Start()
+}

internal/app/components/systray/open_other.go

@@ -1,14 +1,13 @@
-//go:build !darwin && !windows
+//go:build !darwin && !linux && !windows
 
 package systray
 
 import (
 	"context"
-	"os/exec"
+
+	"github.com/y3owk1n/neru/internal/derrors"
 )
 
-// Opens a URL or file path with xdg-open (Linux and other XDG desktops).
-// Does not validate the target or wait for the launched app.
-func openExternal(ctx context.Context, target string) error {
-	return exec.CommandContext(ctx, "xdg-open", target).Run()
+func openExternal(_ context.Context, _ string) error {
+	return derrors.New(derrors.CodeNotSupported, "opening external targets is not supported")
 }

internal/cli/docs.go

@@ -6,8 +6,8 @@ import (
 
 // DocsCmd is the CLI docs command for opening Neru documentation in the browser.
 //
-// macOS: uses open.
-// Other platforms: stubbed and returns CodeNotSupported until implemented.
+// macOS: uses open. Linux: uses xdg-open.
+// Other platforms return CodeNotSupported.
 var DocsCmd = &cobra.Command{
 	Use:   "docs",
 	Short: "Open documentation in the browser",

internal/cli/docs_linux.go

@@ -0,0 +1,22 @@
+//go:build linux
+
+package cli
+
+import (
+	"context"
+	"os/exec"
+
+	"github.com/y3owk1n/neru/internal/buildinfo"
+	"github.com/y3owk1n/neru/internal/derrors"
+)
+
+func openDocsPage(path string) error {
+	url := buildinfo.DocsURL(path, buildinfo.Version)
+
+	err := exec.CommandContext(context.Background(), "xdg-open", url).Start()
+	if err != nil {
+		return derrors.Wrap(err, derrors.CodeExecFailed, "failed to open documentation in browser")
+	}
+
+	return nil
+}

internal/cli/docs_other.go

@@ -1,11 +1,12 @@
-//go:build !darwin
+//go:build !darwin && !linux
 
 package cli
 
-import (
-	"github.com/y3owk1n/neru/internal/derrors"
-)
+import "github.com/y3owk1n/neru/internal/derrors"
 
 func openDocsPage(path string) error {
-	return derrors.New(derrors.CodeNotSupported, "open documentation is only implemented for macOS")
+	return derrors.New(
+		derrors.CodeNotSupported,
+		"open documentation is only implemented for macOS and Linux",
+	)
 }