fix: replace all click actions to use actual mouse click rather than accessibility (#45)

Author: y3owk1n

README.md

@@ -63,7 +63,6 @@ This is an intentional design choice to keep the project lean, maintainable, and
 - Consider zIndex for hints on different layers? There might be multiple layers when we are considering `Menubar`, `Dock` and `Notification bar`
 - Better UI representation for action menu (maybe auto edge detection like tooltip in browser, that will place itself around the element based on the space available around it)
 - Still a bit slow when activating in windows that have huge lists, such as Mail.app without `unread` filter
-- Maybe ditch Accessibility based actions and fully focus on pure mouse click simulation? Noticed that accessibility actions are not very reliable :(
 - Find a way to auto deduplicate hints that are targeting the same point
 - Scroll areas are hardcoded from 1-9, do we ever need more than that and make it dynamic upon query? We can still use <Tab> to cycle next tho
 - Homerow supports `continuous clicks`, is that something important?

cmd/govim/main.go

@@ -593,7 +593,7 @@ func (a *App) handleHintKey(key string) {
 		} else {
 			// Direct click mode - click immediately
 			a.logger.Info("Clicking element", zap.String("label", a.hintInput))
-			if err := hint.Element.Element.Click(); err != nil {
+			if err := hint.Element.Element.LeftClick(); err != nil {
 				a.logger.Error("Failed to click element", zap.Error(err))
 			}
 			a.exitMode()
@@ -714,7 +714,7 @@ func (a *App) handleActionKey(key string) {
 	switch key {
 	case "l": // Left click
 		a.logger.Info("Performing left click", zap.String("label", hint.Label))
-		err = hint.Element.Element.Click()
+		err = hint.Element.Element.LeftClick()
 	case "r": // Right click
 		a.logger.Info("Performing right click", zap.String("label", hint.Label))
 		err = hint.Element.Element.RightClick()

internal/accessibility/element.go

@@ -267,23 +267,18 @@ func (e *Element) GetChildrenCount() int {
 	return int(C.getChildrenCount(e.ref))
 }
 
-// Click performs a click action on the element
-func (e *Element) Click() error {
+// LeftClick performs a click action on the element
+func (e *Element) LeftClick() error {
 	if e.ref == nil {
 		return fmt.Errorf("element is nil")
 	}
 
-	result := C.performClick(e.ref)
+	result := C.performLeftClick(e.ref)
 	if result == 1 {
 		return nil
 	}
 
-	// Fallback to a real mouse click at the element's center
-	if C.clickElementWithMouse(e.ref) == 1 {
-		return nil
-	}
-
-	return fmt.Errorf("click action failed")
+	return fmt.Errorf("left-click action failed")
 }
 
 // RightClick performs a right-click action on the element

internal/bridge/accessibility.h

@@ -18,23 +18,35 @@ typedef struct {
 
 // Function declarations
 int checkAccessibilityPermissions();
+
 void* getSystemWideElement();
 void* getFocusedApplication();
 void* getApplicationByPID(int pid);
 void* getApplicationByBundleId(const char* bundle_id);
 void* getMenuBar(void* app);
+
 ElementInfo* getElementInfo(void* element);
 void freeElementInfo(ElementInfo* info);
+
 void* getElementAtPosition(CGPoint position);
+
 int getChildrenCount(void* element);
 void** getChildren(void* element, int* count);
 void** getVisibleChildren(void* element, int* count, int checkOcclusion);
-int performClick(void* element);
+
+int getElementCenter(void* element, CGPoint* outPoint);
+
+void moveMouse(CGPoint position);
+
+// Click functions - perform click actions on accessibility elements and restore cursor position
+int performLeftClick(void* element);
 int performRightClick(void* element);
 int performDoubleClick(void* element);
 int performMiddleClick(void* element);
+
 int hasClickAction(void* element);
 int setFocus(void* element);
+
 char* getElementAttribute(void* element, const char* attribute);
 void freeString(char* str);
 void releaseElement(void* element);
@@ -51,7 +63,4 @@ int isScrollable(void* element);
 CGRect getScrollBounds(void* element);
 int scrollElement(void* element, int deltaX, int deltaY);
 
-// Mouse click fallback
-int clickElementWithMouse(void* element);
-
 #endif // ACCESSIBILITY_H