fix(hints): ask for screen-capture consent before the contour strategy runs (#1596)

Author: y3owk1n

internal/app/modes/hints.go

@@ -310,10 +310,11 @@ func (h *handlerState) activateHintModeInternal(activation modecmd.Activation) {
 	h.startIndicatorPolling(domain.ModeHints)
 }
 
-// needsScreenCapturePermission reports whether the vision strategy is blocked
-// on the screen-recording permission.
+// needsScreenCapturePermission reports whether a screen-capture strategy is
+// blocked on the screen-recording permission. Vision and contour both read the
+// window's pixels, so both pay the gate. Axtree never touches the screen.
 func (h *handlerState) needsScreenCapturePermission(strategy string) bool {
-	if strategy != domain.StrategyVision {
+	if strategy != domain.StrategyVision && strategy != domain.StrategyContour {
 		return false
 	}
 

internal/app/modes/hints_permission_test.go

@@ -63,14 +63,25 @@ func newVisionHintsHandler(
 	systemMock *portmocks.MockSystemPort,
 	logger *zap.Logger,
 	shutdown func(),
+) *Handler {
+	return newCaptureHintsHandler(domain.StrategyVision, systemMock, logger, shutdown)
+}
+
+// newCaptureHintsHandler builds a handler whose configured hint strategy is
+// strategy and whose screen-capture permission comes from systemMock.
+func newCaptureHintsHandler(
+	strategy string,
+	systemMock *portmocks.MockSystemPort,
+	logger *zap.Logger,
+	shutdown func(),
 ) *Handler {
 	handler := newHandlerWithState(handlerState{
 		ctx:    context.Background(),
 		logger: logger,
 		config: &configpkg.Config{
 			Hints: configpkg.HintsConfig{
 				Enabled:  true,
-				Strategy: domain.StrategyVision,
+				Strategy: strategy,
 			},
 		},
 		appState:      state.NewAppState(),
@@ -121,6 +132,20 @@ func TestActivateMode_PermissionDialogDoesNotBlockOrHoldLock(t *testing.T) {
 	}
 }
 
+func TestActivateMode_ContourStrategyRequestsScreenCapturePermission(t *testing.T) {
+	modal := newPermissionModal()
+	handler := newCaptureHintsHandler(domain.StrategyContour, modal.system, zap.NewNop(), func() {})
+
+	// Contour reads the window's pixels just like vision does, so an
+	// activation without consent must raise the dialog instead of letting the
+	// capture fail under the mode handler's lock.
+	handler.ActivateMode(modecmd.Activation{Mode: domain.ModeHints})
+
+	modal.awaitOpen(t)
+
+	modal.consent <- ports.ScreenCaptureCanceled
+}
+
 func TestResumeHintActivationAfterPermission_DoesNotRepromptWhenCheckStillFails(t *testing.T) {
 	requests := make(chan struct{}, 2)
 	consent := make(chan ports.ScreenCaptureConsent)