fix: real electron support (mess) (#15)

Author: y3owk1n

README.md

@@ -284,11 +284,35 @@ additional_clickable_roles = ["AXStaticText"]
 
 ### Electron & Chrome Support
 
+> [!NOTE]
+> Electron, firefox and chrome support is a mess, and I'm not even sure if I am doing it correctly or not.
+> Feel free to help out if you know better about this...
+
 GoVim includes built-in support for Electron apps (VS Code, Windsurf, Slack, etc.) and Chromium browsers.
 
 - `accessibility.electron_support.enable` toggles automatic enabling of Electron accessibility hooks for legacy apps.
 - `accessibility.electron_support.additional_bundles` accepts exact bundle IDs or `prefix*` wildcards for extra Electron apps that require manual accessibility.
 
+Built-in enabled apps:
+
+- `org.mozilla.firefox` - Firefox
+- `com.microsoft.VSCode` - VS Code
+- `com.exafunction.windsurf` - Windsurf
+- `com.todesktop.230313mzl4w4u92` - Cursor
+- `com.tinyspeck.slackmacgap` - Slack
+- `com.spotify.client` - Spotify
+- `md.obsidian` - Obsidian
+- For other apps, you can add them to `accessibility.electron_support.additional_bundles` in your config, or just submit a PR to add into the source
+
+Note that you don't have to add chromium bundles here. To support it, you need to:
+
+1. Go to `chrome://accessibility`
+2. Turn on `Native accessibility API support`
+3. Turn on `Web accessibility`
+
+> [!NOTE]
+> Not sure if there's a better way to do this... feel free to help out!
+
 ## CLI Usage
 
 GoVim provides a comprehensive CLI with IPC (Inter-Process Communication) for controlling the running daemon.

cmd/govim/main.go

@@ -231,9 +231,6 @@ func (a *App) registerHotkeys() error {
 	}
 
 	// Note: Escape key for exiting modes is hardcoded in handleKeyPress, not registered as global hotkey
-
-	// ...existing code...
-
 	return nil
 }
 
@@ -755,17 +752,17 @@ func (a *App) activateScrollMode() {
 	// Update roles for the current focused app
 	a.updateRolesForCurrentApp()
 
+	if a.config.Accessibility.ElectronSupport.Enable {
+		accessibility.EnsureElectronSupport(a.config.Accessibility.ElectronSupport.AdditionalBundles)
+	}
+
 	a.logger.Info("Initializing scroll controller")
 	// Activate scroll mode
 	if err := a.scrollController.Initialize(); err != nil {
 		a.logger.Error("Failed to initialize scroll controller", zap.Error(err))
 		return
 	}
 
-	if a.config.Accessibility.ElectronSupport.Enable {
-		accessibility.EnsureElectronSupport(a.config.Accessibility.ElectronSupport.AdditionalBundles)
-	}
-
 	a.logger.Info("Getting scroll areas")
 	// Get all scroll areas
 	areas := a.scrollController.GetAllAreas()
@@ -858,15 +855,13 @@ func (a *App) exitMode() {
 		a.eventTap.Disable()
 	}
 
-	if a.config.Accessibility.ElectronSupport.Enable {
-		accessibility.ResetElectronSupport()
-	}
+	// if a.config.Accessibility.ElectronSupport.Enable {
+	// 	accessibility.ResetElectronSupport()
+	// }
 
 	a.currentMode = ModeIdle
 }
 
-// ...existing code...
-
 // getModeString returns the current mode as a string
 func (a *App) getModeString() string {
 	switch a.currentMode {

configs/default-config.toml

@@ -38,35 +38,14 @@ scrollable_roles = [
 # The roles defined here are ADDED to the global roles above (not replaced)
 # To find an app's bundle ID, run: osascript -e 'id of app "AppName"'
 
-# Example: Add custom roles for Safari
+# For example, in `Mail.app`, lots of element are `AXStaticText` and they should be clickable. In this case, we don't want to add to the global one, as it will causes lots of unclickable hints, especially in browser space.
 # [[accessibility.app_configs]]
-# bundle_id = "com.apple.Safari"
-# additional_clickable_roles = ["AXGroup", "AXImage"]
-# additional_scrollable_roles = ["AXWebArea"]
-
-# Example: Add custom roles for Firefox
-# [[accessibility.app_configs]]
-# bundle_id = "org.mozilla.firefox"
-# additional_clickable_roles = ["AXGroup"]
-# additional_scrollable_roles = []
-
-# Example: Add custom roles for VS Code
-# [[accessibility.app_configs]]
-# bundle_id = "com.microsoft.VSCode"
+# bundle_id = "com.apple.mail"
 # additional_clickable_roles = ["AXStaticText"]
-# additional_scrollable_roles = ["AXGroup"]
 
 [accessibility.electron_support]
 enable = true
-# Add Chrome and Chromium-based browsers for web app support
-# Windsurf is already included in the default list
-additional_bundles = [
-    "com.google.Chrome",
-    "com.google.Chrome.canary",
-    "com.brave.Browser",
-    "com.microsoft.edgemac",
-    "org.chromium.Chromium",
-]
+additional_bundles = []
 
 [hotkeys]
 # all hotkeys can be disabled by either setting the key to "" or just commenting it out
@@ -80,7 +59,6 @@ activate_hint_mode_with_actions = "Cmd+Shift+A"
 # Activate scroll mode for vim-style scrolling
 activate_scroll_mode = "Cmd+Shift+J"
 
-
 # Note: Escape key is hardcoded to exit any active mode
 
 [hints]

internal/accessibility/accessible_apps.go

@@ -2,27 +2,15 @@ package accessibility
 
 import "strings"
 
-var (
-	// KnownElectronPrefixes lists bundle identifier prefixes commonly backed by Electron.
-	KnownElectronPrefixes = []string{
-		"com.microsoft.vscode",
-		"com.microsoft.vscodeinsiders",
-		"com.slack.",
-		"com.github.",
-		"com.todesktop.",
-		"com.zoom.",
-		"md.obsidian",
-	}
-
-	// KnownElectronExact matches bundle identifiers observed to require manual accessibility.
-	KnownElectronExact = []string{
-		"com.sindresorhus.helium",
-		"com.sindresorhus.helium2",
-		"com.tinyspeck.slackmacgap",
-		"com.microsoft.teams",
-		"com.exafunction.windsurf",
-	}
-)
+var KnownElectronBundles = []string{
+	"org.mozilla.firefox", // NOTE: why is this here? It's not an electron app, but the same logic to enable `AXEnhancedUserInterface`. Put it here first until we have a better manager for this.
+	"com.microsoft.VSCode",
+	"com.exafunction.windsurf",
+	"com.todesktop.230313mzl4w4u92",
+	"com.tinyspeck.slackmacgap",
+	"com.spotify.client",
+	"md.obsidian",
+}
 
 // ShouldEnableElectronSupport determines if the provided bundle identifier
 // should have Electron accessibility manually toggled based on defaults and
@@ -47,23 +35,12 @@ func IsLikelyElectronBundle(bundleID string) bool {
 		return false
 	}
 
-	for _, exact := range KnownElectronExact {
+	for _, exact := range KnownElectronBundles {
 		if strings.EqualFold(strings.TrimSpace(exact), lower) {
 			return true
 		}
 	}
 
-	for _, prefix := range KnownElectronPrefixes {
-		p := strings.ToLower(strings.TrimSpace(prefix))
-		if p == "" {
-			continue
-		}
-		p = strings.TrimSuffix(p, "*")
-		if strings.HasPrefix(lower, p) {
-			return true
-		}
-	}
-
 	return false
 }
 

internal/accessibility/accessible_apps_test.go

@@ -8,26 +8,14 @@ func TestIsLikelyElectronBundle(t *testing.T) {
 		bundleID string
 		want     bool
 	}{
-		// Exact matches
+		{"Firefox", "org.mozilla.firefox", true},
 		{"Windsurf", "com.exafunction.windsurf", true},
-		{"Teams", "com.microsoft.teams", true},
-		{"Helium", "com.sindresorhus.helium", true},
-		{"Slack", "com.tinyspeck.slackmacgap", true},
-
-		// Prefix matches
-		{"VS Code", "com.microsoft.VSCode", true},
-		{"VS Code Insiders", "com.microsoft.VSCodeInsiders", true},
-		{"Slack Desktop", "com.slack.Slack", true},
-		{"GitHub Desktop", "com.github.GitHubClient", true},
-		{"Zoom", "com.zoom.us.Zoom", true},
-		{"Obsidian", "md.obsidian", true},
-		{"ToDesktop App", "com.todesktop.myapp", true},
+		{"Visual Studio Code", "com.microsoft.VSCode", true},
 
 		// Non-Electron apps
 		{"Safari", "com.apple.Safari", false},
 		{"Finder", "com.apple.finder", false},
 		{"Chrome", "com.google.Chrome", false},
-		{"Firefox", "org.mozilla.firefox", false},
 
 		// Edge cases
 		{"Empty", "", false},

internal/accessibility/element.go

@@ -7,6 +7,7 @@ package accessibility
 
 */
 import "C"
+
 import (
 	"fmt"
 	"image"
@@ -25,7 +26,10 @@ type Element struct {
 	ref unsafe.Pointer
 }
 
-const electronAttributeName = "AXManualAccessibility"
+const (
+	electronAttributeName = "AXManualAccessibility"
+	enhancedAttributeName = "AXEnhancedUserInterface"
+)
 
 var (
 	clickableRoles   = make(map[string]struct{})
@@ -513,16 +517,26 @@ func ensureElectronAccessibility(pid int, bundleID string) bool {
 		return true
 	}
 
-	if !bridge.SetApplicationAttribute(pid, electronAttributeName, true) {
-		logger.Warn("Failed to enable Electron accessibility", zap.Int("pid", pid), zap.String("bundle_id", bundleID))
+	successSetElectron := bridge.SetApplicationAttribute(pid, electronAttributeName, true)
+
+	if successSetElectron {
+		logger.Debug("Enabled AXManualAccessibility", zap.Int("pid", pid), zap.String("bundle_id", bundleID))
+	}
+
+	successSetEnhanced := bridge.SetApplicationAttribute(pid, enhancedAttributeName, true)
+
+	if successSetEnhanced {
+		logger.Debug("Enabled AXEnhancedUserInterface", zap.Int("pid", pid), zap.String("bundle_id", bundleID))
+	}
+
+	if !successSetEnhanced && !successSetElectron {
+		logger.Warn("Failed to enable AXManualAccessibility or AXEnhancedUserInterface", zap.Int("pid", pid), zap.String("bundle_id", bundleID))
 		return false
 	}
 
 	electronPIDsMu.Lock()
 	electronEnabledPIDs[pid] = struct{}{}
 	electronPIDsMu.Unlock()
-
-	logger.Debug("Enabled AXManualAccessibility", zap.Int("pid", pid), zap.String("bundle_id", bundleID))
 	return true
 }