chore: remove redundant comments across the codebase (#1535)

Author: y3owk1n

internal/adapter/accessibility/adapter.go

@@ -53,9 +53,7 @@ var elementSlicePool = sync.Pool{
 }
 
 // Adapter implements ports.AccessibilityPort by wrapping the ax.Client.
-// It converts between domain models and infrastructure types.
 type Adapter struct {
-	// logger for adapter.
 	logger               *zap.Logger
 	client               ax.Client
 	excludedBundles      map[string]bool
@@ -86,13 +84,11 @@ func NewAdapter(
 }
 
 // Logger returns the logger for the adapter.
-// It is used for testing mainly.
 func (a *Adapter) Logger() *zap.Logger {
 	return a.logger
 }
 
 // ClickableRoles returns the list of clickable roles.
-// It is used for testing mainly.
 func (a *Adapter) ClickableRoles() []string {
 	return a.clickableRoles
 }
@@ -179,7 +175,6 @@ func (a *Adapter) PerformAction(
 	element *element.Element,
 	actionType action.Type,
 ) error {
-	// Check context
 	select {
 	case <-ctx.Done():
 		return derrors.Wrap(ctx.Err(), derrors.CodeContextCanceled, "operation canceled")
@@ -283,8 +278,6 @@ func (a *Adapter) IsAppExcluded(_ context.Context, bundleID string) bool {
 }
 
 // ReleaseHeldButtons releases any mouse button this process still holds down.
-// The per-platform release lives in element_<os>.go; it is unexported because
-// only this adapter and the infra client may reach it.
 func (a *Adapter) ReleaseHeldButtons(ctx context.Context) error {
 	err := a.checkContext(ctx)
 	if err != nil {
@@ -356,16 +349,14 @@ func (a *Adapter) processClickableNodes(
 	clickableNodes []ax.Node,
 	filter ports.ElementFilter,
 ) ([]*element.Element, error) {
-	// Get pooled slice and reset it
 	elementsPtr, ok := elementSlicePool.Get().(*[]*element.Element)
 	if !ok {
 		s := make([]*element.Element, 0, TypicalElementCount)
 		elementsPtr = &s
 	}
 
-	elements := (*elementsPtr)[:0] // Reset to zero length but keep capacity
+	elements := (*elementsPtr)[:0]
 	defer func() {
-		// Clear references before returning to pool
 		for i := range elements {
 			elements[i] = nil
 		}
@@ -381,13 +372,11 @@ func (a *Adapter) processClickableNodes(
 		)
 	}()
 
-	// Concurrent processing for large number of nodes
 	if len(clickableNodes) > ConcurrentProcessingThreshold {
 		return a.processClickableNodesConcurrent(ctx, clickableNodes, filter)
 	}
 
 	for index, node := range clickableNodes {
-		// Check context periodically
 		if index%contextCheckInterval == 0 {
 			err := a.checkContext(ctx)
 			if err != nil {
@@ -418,7 +407,6 @@ func (a *Adapter) processClickableNodes(
 		}
 	}
 
-	// Make a copy to return since we're returning the pooled slice
 	result := make([]*element.Element, len(elements))
 	copy(result, elements)
 
@@ -432,9 +420,7 @@ func (a *Adapter) processClickableNodesConcurrent(
 	filter ports.ElementFilter,
 ) ([]*element.Element, error) {
 	numWorkers := min(
-		// Use available parallelism
 		runtime.GOMAXPROCS(0),
-		// Cap to avoid diminishing returns
 		maxConcurrentWorkers)
 
 	chunkSize := (len(nodes) + numWorkers - 1) / numWorkers
@@ -464,7 +450,6 @@ func (a *Adapter) processClickableNodesConcurrent(
 		go func(chunk []ax.Node) {
 			defer waitGroup.Done()
 
-			// Use local slice to avoid locking
 			localElements := make([]*element.Element, 0, len(chunk))
 
 			for idx, node := range chunk {
@@ -501,8 +486,6 @@ func (a *Adapter) processClickableNodesConcurrent(
 		close(results)
 	}()
 
-	// Collect results
-	// Pre-allocate based on input size estimate (conservative)
 	allElements := make([]*element.Element, 0, len(nodes)/EstimatedFilteringRatio)
 
 	for res := range results {

internal/adapter/accessibility/adapter_conversion.go

@@ -12,16 +12,9 @@ func (a *Adapter) convertToDomainElement(node ax.Node) (*element.Element, error)
 		return nil, derrors.New(derrors.CodeInvalidInput, "node is nil")
 	}
 
-	// Create element ID from unique identifier
 	elementID := element.ID(node.ID())
-
-	// Get bounds
 	bounds := node.Bounds()
-
-	// Convert role
 	role := element.Role(node.Role())
-
-	// Determine if clickable
 	isClickable := node.IsClickable()
 
 	searchText := ""

internal/adapter/accessibility/adapter_filtering.go

@@ -16,28 +16,22 @@ func (a *Adapter) MatchesFilter(
 	elem *element.Element,
 	filter ports.ElementFilter,
 ) bool {
-	// Check minimum size
 	bounds := elem.Bounds()
 	if bounds.Dx() < filter.MinSize.X || bounds.Dy() < filter.MinSize.Y {
 		return false
 	}
 
-	// Check role inclusion
 	if len(filter.Roles) > 0 {
 		found := slices.Contains(filter.Roles, elem.Role())
 		if !found {
 			return false
 		}
 	}
 
-	// Check role exclusion
 	if slices.Contains(filter.ExcludeRoles, elem.Role()) {
 		return false
 	}
 
-	// Check title contains filter
-	// NOTE: filter.TitleContains is expected to be pre-lowercased by the caller (e.g. ClickableElements).
-	// Direct callers of MatchesFilter must also lowercase filter strings before passing them.
 	titleMatched := false
 	if filter.TitleContains != "" {
 		title := elem.Title()
@@ -47,7 +41,6 @@ func (a *Adapter) MatchesFilter(
 		}
 	}
 
-	// Check description contains filter
 	descMatched := false
 	if filter.DescriptionContains != "" {
 		description := elem.Description()
@@ -60,7 +53,6 @@ func (a *Adapter) MatchesFilter(
 		}
 	}
 
-	// Check value contains filter
 	valueMatched := false
 	if filter.ValueContains != "" {
 		value := textForFilter(elem)
@@ -70,7 +62,6 @@ func (a *Adapter) MatchesFilter(
 		}
 	}
 
-	// Check any of the additional text substrings match (OR logic)
 	textListMatched := false
 	if len(filter.TextContainsList) > 0 {
 		title := elem.Title()

internal/adapter/overlay/render/grid/overlay_darwin.go

@@ -370,7 +370,6 @@ func (o *Overlay) DrawGrid(grid *domainGrid.Grid, currentInput string, style Sty
 		runtime.ReadMemStats(&msBefore)
 	}
 
-	// Check if we can do incremental updates (always try if we have previous state)
 	o.gridStateMu.RLock()
 	canIncrementalUpdate := o.previousGrid != nil
 	o.gridStateMu.RUnlock()
@@ -582,7 +581,6 @@ func (o *Overlay) drawGridIncremental(
 		return false // No previous state to compare against
 	}
 
-	// Check if only the input changed (common case for typing)
 	if o.gridsAreStructurallyEqual(grid, previousGrid) && style == previousStyle {
 		// Only input changed - we can do incremental match updates
 		if currentInput != previousInput {
@@ -623,7 +621,6 @@ func (o *Overlay) gridsAreStructurallyEqual(a, b *domainGrid.Grid) bool {
 		return false
 	}
 
-	// Check if all cells have the same coordinates and bounds
 	for i, aCell := range aCells {
 		bCell := bCells[i]
 		if aCell.Coordinate() != bCell.Coordinate() ||

internal/adapter/overlay/render/hints/overlay_darwin.go

@@ -410,7 +410,6 @@ func (o *Overlay) drawHintsInternal(hints []*Hint, style StyleMode, showArrow bo
 		}
 	}
 
-	// Check if we can do incremental updates
 	o.hintStateMu.RLock()
 	canIncrementalUpdate := len(o.previousHints) > 0
 	o.hintStateMu.RUnlock()
@@ -571,7 +570,6 @@ func (o *Overlay) drawHintsIncremental(
 		return false // No previous state to compare against
 	}
 
-	// Check if only the input changed (common case for typing)
 	if o.hintsAreStructurallyEqual(hints, previousHints) && style == previousStyle {
 		// Only input changed - we can do incremental match updates
 		if currentInput != previousInput {

internal/adapter/overlay/render/overlayutil/util.go

@@ -75,19 +75,16 @@ func releaseCallbackID(callbackID uint64) {
 
 	if !allocatedCallbackIDs[callbackID] {
 		allocatedCallbackIDsMu.Unlock()
-		// ID is not allocated, nothing to release
 		return
 	}
 
 	delete(allocatedCallbackIDs, callbackID)
 	allocatedCallbackIDsMu.Unlock()
 
-	// Remove from global registry
 	callbackManagerRegistryMu.Lock()
 	delete(callbackManagerRegistry, callbackID)
 	callbackManagerRegistryMu.Unlock()
 
-	// Return the ID to the free pool for reuse
 	freeCallbackIDsMu.Lock()
 
 	freeCallbackIDs = append(freeCallbackIDs, callbackID)
@@ -127,16 +124,11 @@ func CompleteGlobalCallback(callbackID uint64, expectedGeneration uint64) {
 		return
 	}
 
-	// Atomically remove the registry entry so no concurrent deferred release
-	// or new allocation can race with us on this callback ID.
 	delete(callbackManagerRegistry, callbackID)
 	callbackManagerRegistryMu.Unlock()
 
 	entry.manager.CompleteCallback(callbackID)
 
-	// Return the ID to the free pool. Since we already deleted the registry
-	// entry above, releaseCallbackID will skip the registry delete (no-op)
-	// but will still clear allocatedCallbackIDs and return the ID to the pool.
 	releaseCallbackID(callbackID)
 }
 
@@ -269,10 +261,7 @@ func (c *CallbackManager) CompleteCallback(callbackID uint64) {
 // This should be called when the overlay is being destroyed.
 // Safe to call multiple times - only executes cleanup once.
 func (c *CallbackManager) Cleanup() {
-	// Use sync.Once to ensure cleanup only happens once
-	// This prevents panic from double-close of the cancel channel
 	c.cleanupOnce.Do(func() {
-		// Close the cancel channel to stop all background goroutines
 		close(c.cancelCh)
 
 		// Snapshot and clear callbackMap under callbackMu first, then remove

internal/adapter/overlay/render/recursivegrid/overlay_darwin.go

@@ -31,9 +31,7 @@ import (
 
 //export recursiveGridResizeCompletionCallback
 func recursiveGridResizeCompletionCallback(context unsafe.Pointer) {
-	// Read callback context from the C-heap-allocated CallbackContext
 	ctx := *(*overlayutil.CallbackContext)(context)
-	// Free the C-allocated context now that we've copied the values
 	overlayutil.FreeCallbackContext(context)
 	overlayutil.CompleteGlobalCallback(ctx.CallbackID, ctx.Generation)
 }
@@ -304,7 +302,6 @@ func (o *Overlay) DrawRecursiveGrid(
 	dims = usableDims
 	keyCount := dims.CellCount()
 
-	// Validate keys length matches grid dimensions
 	keyRunes := []rune(keys)
 	if len(keyRunes) != keyCount {
 		o.logger.Warn(
@@ -316,7 +313,6 @@ func (o *Overlay) DrawRecursiveGrid(
 	// draw call so that freeLabelCache cannot free labels mid-draw.
 	o.drawMu.RLock()
 
-	// Compute cell positions using the shared helper (same as Divide()).
 	cellRects := recursivegrid.ComputeGridCells(bounds, dims)
 
 	cells := make([]C.GridCell, keyCount)
@@ -339,9 +335,6 @@ func (o *Overlay) DrawRecursiveGrid(
 		}
 	}
 
-	// Build sub-key preview labels.
-	// When a label char override is set, repeat it to match the grid cell count
-	// so the native renderer gets the expected number of labels.
 	subKeyLabel := style.SubKeyPreviewLabelChar()
 	if subKeyLabel != "" {
 		subKeyLabel = strings.Repeat(subKeyLabel, nextDims.CellCount())

internal/app/config.go

@@ -40,23 +40,20 @@ func (a *App) SetConfigField(ctx context.Context, key, value string) error {
 		return err
 	}
 
-	// Validate the new config.
 	valErr := newCfg.Validate()
 	if valErr != nil {
 		a.restoreHotkeysAfterFailedReload()
 
 		return derrors.Wrap(valErr, derrors.CodeInvalidConfig, "config-set validation")
 	}
 
-	// Update the config service (notifies watchers with the new config).
 	updateErr := a.configService.Update(newCfg, newWritten)
 	if updateErr != nil {
 		a.restoreHotkeysAfterFailedReload()
 
 		return updateErr
 	}
 
-	// Build a LoadResult for the reconfiguration helpers.
 	loadResult := &config.LoadResult{
 		Config:     newCfg,
 		Written:    newWritten,

internal/app/getters.go

@@ -132,7 +132,6 @@ func (a *App) IsOverlayHiddenForScreenShare() bool {
 
 // SetOverlayHiddenForScreenShare sets whether the overlay should be hidden from screen sharing.
 func (a *App) SetOverlayHiddenForScreenShare(hide bool) {
-	// Update app state (this will trigger callbacks)
 	a.appState.SetHiddenForScreenShare(hide)
 }
 

internal/app/ipcctrl/info.go

@@ -131,7 +131,6 @@ func (h *InfoHandler) ResolveConfigPath() string {
 		return "using default config"
 	}
 
-	// Check if the config file actually exists
 	_, err := os.Stat(configPath)
 	if os.IsNotExist(err) {
 		return "using default config"