fix(cli): open the docs on Windows, where the tray already knows how (#1620)

Author: y3owk1n

docs/CLI.md

@@ -99,7 +99,7 @@ Accepted by every command.
 | [`toggle-screen-share`](#neru-toggle-screen-share)           | Hide overlays while sharing     | Yes | macOS |
 | [`roles`](#neru-roles)                                       | List the role vocabulary        | No  | All |
 | [`services`](#neru-services)                                 | Manage the system service       | No  | macOS · Linux |
-| [`docs`](#neru-docs)                                         | Open documentation in a browser | No  | macOS · Linux |
+| [`docs`](#neru-docs)                                         | Open documentation in a browser | No  | All |
 
 ¹ Element discovery quality differs by platform: a full accessibility tree on
 macOS, an AT-SPI walk on Linux whose coverage depends on the application, and a
@@ -1561,7 +1561,8 @@ Open documentation in a browser.
 neru docs config|cli
 ```
 
-**Platforms:** macOS and Linux; other platforms return `ERR_NOT_SUPPORTED`.
+**Platforms:** all. The page opens with the desktop's default handler (`open`,
+`xdg-open`, or `rundll32`).
 
 URLs point at the Git tag matching the installed version. Development builds
 fall back to `main`.

internal/adapter/platform/open_darwin.go

@@ -0,0 +1,21 @@
+//go:build darwin
+
+package platform
+
+import (
+	"context"
+	"os/exec"
+
+	"github.com/y3owk1n/neru/internal/derrors"
+)
+
+// OpenExternal opens a URL or file path with the macOS default handler.
+// It does not validate the target or wait for the launched app.
+func OpenExternal(ctx context.Context, target string) error {
+	err := exec.CommandContext(ctx, "/usr/bin/open", target).Run()
+	if err != nil {
+		return derrors.Wrap(err, derrors.CodeExecFailed, "failed to launch the system open handler")
+	}
+
+	return nil
+}

internal/adapter/platform/open_linux.go

@@ -0,0 +1,21 @@
+//go:build linux
+
+package platform
+
+import (
+	"context"
+	"os/exec"
+
+	"github.com/y3owk1n/neru/internal/derrors"
+)
+
+// OpenExternal opens a URL or file path with the Linux desktop's default
+// handler. It does not validate the target or wait for the launched app.
+func OpenExternal(ctx context.Context, target string) error {
+	err := exec.CommandContext(ctx, "xdg-open", target).Start()
+	if err != nil {
+		return derrors.Wrap(err, derrors.CodeExecFailed, "failed to launch the system open handler")
+	}
+
+	return nil
+}

…nal/app/components/systray/open_other.go internal/adapter/platform/open_other.gointernal/app/components/systray/open_other.go renamed to internal/adapter/platform/open_other.go internal/app/components/systray/open_other.go renamed to internal/adapter/platform/open_other.go

@@ -1,13 +1,14 @@
 //go:build !darwin && !linux && !windows
 
-package systray
+package platform
 
 import (
 	"context"
 
 	"github.com/y3owk1n/neru/internal/derrors"
 )
 
-func openExternal(_ context.Context, _ string) error {
+// OpenExternal is the non-target fallback: no handler is known here.
+func OpenExternal(_ context.Context, _ string) error {
 	return derrors.New(derrors.CodeNotSupported, "opening external targets is not supported")
 }

internal/adapter/platform/open_test.go

@@ -0,0 +1,34 @@
+package platform_test
+
+import (
+	"context"
+	"runtime"
+	"testing"
+
+	"github.com/y3owk1n/neru/internal/adapter/platform"
+	"github.com/y3owk1n/neru/internal/derrors"
+)
+
+// An already-canceled context makes the launch fail before anything is
+// spawned, so this runs everywhere without opening a browser. The shipped
+// platforms report the failed launch, and the fallback slot refuses.
+func TestOpenExternalReportsALaunchFailure(t *testing.T) {
+	ctx, cancel := context.WithCancel(context.Background())
+	cancel()
+
+	err := platform.OpenExternal(ctx, "https://example.invalid")
+	if err == nil {
+		t.Fatal("OpenExternal() = nil, want an error when the handler cannot launch")
+	}
+
+	wantCode := derrors.CodeNotSupported
+
+	switch runtime.GOOS {
+	case string(platform.Darwin), string(platform.Linux), string(platform.Windows):
+		wantCode = derrors.CodeExecFailed
+	}
+
+	if !derrors.IsCode(err, wantCode) {
+		t.Errorf("OpenExternal() error = %v, want code %s", err, wantCode)
+	}
+}

internal/adapter/platform/open_windows.go

@@ -0,0 +1,23 @@
+//go:build windows
+
+package platform
+
+import (
+	"context"
+	"os/exec"
+
+	"github.com/y3owk1n/neru/internal/derrors"
+)
+
+// OpenExternal opens a URL or file path with the Windows default handler via
+// rundll32. It does not validate the target or wait for the launched app.
+func OpenExternal(ctx context.Context, target string) error {
+	// rundll32 url.dll,FileProtocolHandler handles both URLs and file paths
+	// using the registered default application, with no console window flash.
+	err := exec.CommandContext(ctx, "rundll32", "url.dll,FileProtocolHandler", target).Run()
+	if err != nil {
+		return derrors.Wrap(err, derrors.CodeExecFailed, "failed to launch the system open handler")
+	}
+
+	return nil
+}

internal/app/components/systray/open_darwin.go

@@ -7,6 +7,7 @@ import (
 	"github.com/atotto/clipboard"
 	"go.uber.org/zap"
 
+	"github.com/y3owk1n/neru/internal/adapter/platform"
 	"github.com/y3owk1n/neru/internal/buildinfo"
 	"github.com/y3owk1n/neru/internal/domain"
 	"github.com/y3owk1n/neru/internal/ports"
@@ -290,14 +291,14 @@ func (c *Component) handleEvents() {
 			go c.handleOpenConfig()
 		case <-c.mSourceCode.Clicked():
 			go func() {
-				err := openExternal(c.ctx, "https://github.com/y3owk1n/neru")
+				err := platform.OpenExternal(c.ctx, "https://github.com/y3owk1n/neru")
 				if err != nil {
 					c.logger.Error("Failed to open repository", zap.Error(err))
 				}
 			}()
 		case <-c.mDocsConfig.Clicked():
 			go func() {
-				err := openExternal(
+				err := platform.OpenExternal(
 					c.ctx,
 					buildinfo.DocsURL("docs/CONFIGURATION.md", buildinfo.Version),
 				)
@@ -307,14 +308,17 @@ func (c *Component) handleEvents() {
 			}()
 		case <-c.mDocsCLI.Clicked():
 			go func() {
-				err := openExternal(c.ctx, buildinfo.DocsURL("docs/CLI.md", buildinfo.Version))
+				err := platform.OpenExternal(
+					c.ctx,
+					buildinfo.DocsURL("docs/CLI.md", buildinfo.Version),
+				)
 				if err != nil {
 					c.logger.Error("Failed to open CLI docs", zap.Error(err))
 				}
 			}()
 		case <-c.mFeatureRequest.Clicked():
 			go func() {
-				err := openExternal(
+				err := platform.OpenExternal(
 					c.ctx,
 					"https://github.com/y3owk1n/neru/issues/new?template=feature_request.yml",
 				)
@@ -324,7 +328,7 @@ func (c *Component) handleEvents() {
 			}()
 		case <-c.mReportBug.Clicked():
 			go func() {
-				err := openExternal(
+				err := platform.OpenExternal(
 					c.ctx,
 					"https://github.com/y3owk1n/neru/issues/new?template=bug_report.yml",
 				)
@@ -334,7 +338,7 @@ func (c *Component) handleEvents() {
 			}()
 		case <-c.mDiscuss.Clicked():
 			go func() {
-				err := openExternal(c.ctx, "https://github.com/y3owk1n/neru/discussions")
+				err := platform.OpenExternal(c.ctx, "https://github.com/y3owk1n/neru/discussions")
 				if err != nil {
 					c.logger.Error("Failed to open community discussion", zap.Error(err))
 				}
@@ -405,7 +409,7 @@ func (c *Component) handleOpenConfig() {
 		return
 	}
 
-	err := openExternal(c.ctx, configPath)
+	err := platform.OpenExternal(c.ctx, configPath)
 	if err != nil {
 		c.logger.Error("Failed to open config file", zap.Error(err))
 	}