Merge pull request #151 from xscriptor/update/plugins

update remove function plugins

Author: xscriptor

src/main.rs

@@ -5,7 +5,7 @@ mod ui;
 
 use crate::config::{generate_config, load_config};
 use crate::info::Info;
-use crate::plugins::{install_plugin, list_plugins};
+use crate::plugins::{install_plugin, list_plugins, remove_plugin};
 use crate::ui::draw;
 use clap::{Parser, Subcommand};
 
@@ -15,7 +15,7 @@ use clap::{Parser, Subcommand};
     version,
     about,
     long_about = None,
-    after_help = "Examples:\n  xfetch\n  xfetch --config ~/.config/xfetch/config.jsonc\n  xfetch --gen-config\n  xfetch plugin install ./plugins/animate-logo\n  xfetch plugin list"
+    after_help = "Examples:\n  xfetch\n  xfetch --config ~/.config/xfetch/config.jsonc\n  xfetch --gen-config\n  xfetch plugin install ./plugins/animate-logo\n  xfetch plugin list\n  xfetch plugin remove animate-logo"
 )]
 struct Cli {
     #[command(subcommand)]
@@ -57,6 +57,11 @@ enum PluginCommands {
     },
     /// List installed plugins
     List,
+    /// Remove an installed plugin
+    Remove {
+        /// Name of the plugin to remove (e.g., animate-logo)
+        name: String,
+    },
 }
 
 fn main() {
@@ -106,6 +111,15 @@ fn main() {
                     }
                 }
             }
+            PluginCommands::Remove { name } => {
+                match remove_plugin(&name) {
+                    Ok(()) => {}
+                    Err(err) => {
+                        eprintln!("Error: {}", err);
+                        std::process::exit(1);
+                    }
+                }
+            }
         },
         None => {
             // Normal fetch behavior

src/plugins.rs

@@ -189,8 +189,6 @@ fn install_remote_plugin(name: &str, repo_url: &str) -> Result<(), String> {
         .args([
             "clone",
             "--depth", "1",
-            "--filter=blob:none",
-            "--sparse",
             repo_url,
         ])
         .arg(&temp_dir)
@@ -204,15 +202,7 @@ fn install_remote_plugin(name: &str, repo_url: &str) -> Result<(), String> {
         return Err("Failed to clone repository".to_string());
     }
 
-    let sparse_checkout = Command::new("git")
-        .args(["sparse-checkout", "set", &format!("plugins/{}", name)])
-        .current_dir(&temp_dir)
-        .stdout(Stdio::inherit())
-        .stderr(Stdio::inherit())
-        .status()
-        .map_err(|_| "Failed to set sparse checkout".to_string())?;
-
-    if !sparse_checkout.success() || !plugin_path.is_dir() {
+    if !plugin_path.is_dir() {
         let _ = fs::remove_dir_all(&temp_dir);
         return Err(format!(
             "Plugin '{}' not found in repository '{}'.\n\
@@ -227,6 +217,25 @@ fn install_remote_plugin(name: &str, repo_url: &str) -> Result<(), String> {
     result
 }
 
+pub fn remove_plugin(name: &str) -> Result<(), String> {
+    let binary_name = plugin_binary_name(name);
+    let plugin_dir = default_plugin_dir();
+    let binary_path = plugin_dir.join(&binary_name);
+
+    if binary_path.is_file() {
+        fs::remove_file(&binary_path)
+            .map_err(|err| format!("Failed to remove plugin '{}': {}", name, err))?;
+        println!("Removed plugin '{}'", name);
+        Ok(())
+    } else {
+        Err(format!(
+            "Plugin '{}' is not installed (not found at {})",
+            name,
+            binary_path.display()
+        ))
+    }
+}
+
 pub fn list_plugins() -> Result<Vec<(String, PathBuf)>, String> {
     let mut plugins = Vec::new();