Skip to content

test: share gRPC plugin header forwarding tests#2883

Open
asoorm wants to merge 1 commit into
ludwig/eng-9615-router-plugin-metadata-overwritten-in-grpc-plugin-middlewarefrom
ahmet/refactor-grpc-plugin-header-tests
Open

test: share gRPC plugin header forwarding tests#2883
asoorm wants to merge 1 commit into
ludwig/eng-9615-router-plugin-metadata-overwritten-in-grpc-plugin-middlewarefrom
ahmet/refactor-grpc-plugin-header-tests

Conversation

@asoorm
Copy link
Copy Markdown
Contributor

@asoorm asoorm commented May 21, 2026

Optional follow-up on #2877. Feel free to take or leave.

Dedupes the standard and OCI header-forwarding suites via a shared testenv.RunGRPCPluginHeaderCases helper.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b23932bf-b842-4c76-9038-aa6cda4d5c54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a652882-0f19-4227-88e1-90979868e434

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-3c64c9c3900cd73a2feed1927297cb341e336c7b

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.28%. Comparing base (a5765a1) to head (e98500d).

Additional details and impacted files
@@                                               Coverage Diff                                                @@
##           ludwig/eng-9615-router-plugin-metadata-overwritten-in-grpc-plugin-middleware    #2883      +/-   ##
================================================================================================================
+ Coverage                                                                         66.24%   66.28%   +0.03%     
================================================================================================================
  Files                                                                               258      258              
  Lines                                                                             27064    27064              
================================================================================================================
+ Hits                                                                              17929    17939      +10     
+ Misses                                                                             7723     7713      -10     
  Partials                                                                           1412     1412              

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asoorm asoorm marked this pull request as ready for review May 21, 2026 13:53
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant