Add tests

Author: Gérald Barré

tests/Workleap.DotNet.CodingStandards.Tests/CodingStandardTests.cs

@@ -17,6 +17,29 @@ public async Task BannedSymbolsAreReported()
         Assert.True(data.HasWarning("RS0030"));
     }
 
+    [Fact]
+    public async Task BannedNewtonsoftJsonSymbolsAreReportedWhenPropertyIsSet()
+    {
+        using var project = new ProjectBuilder(fixture, testOutputHelper);
+        project.AddCsprojFile(
+            properties: new Dictionary<string, string> { { "BanNewtonsoftJsonSymbols", "true" } },
+            packageReferences: new Dictionary<string, string> { { "Newtonsoft.Json", "13.0.1" } });
+        project.AddFile("sample.cs", "_ = Newtonsoft.Json.JsonConvert.SerializeObject(new object());");
+        var data = await project.BuildAndGetOutput();
+        Assert.True(data.HasWarning("RS0030"));
+    }
+
+    [Fact]
+    public async Task BannedNewtonsoftJsonSymbolsAreNotReportedWhenPropertyIsNotSet()
+    {
+        using var project = new ProjectBuilder(fixture, testOutputHelper);
+        project.AddCsprojFile(
+            packageReferences: new Dictionary<string, string> { { "Newtonsoft.Json", "13.0.1" } });
+        project.AddFile("sample.cs", "_ = Newtonsoft.Json.JsonConvert.SerializeObject(new object());");
+        var data = await project.BuildAndGetOutput();
+        Assert.False(data.HasWarning("RS0030"));
+    }
+
     [Fact]
     public async Task WarningsAsErrorOnGitHubActions()
     {

tests/Workleap.DotNet.CodingStandards.Tests/Helpers/ProjectBuilder.cs

@@ -56,7 +56,7 @@ public void AddCsprojFile(Dictionary<string, string>? properties = null, Diction
         {
             foreach (var prop in properties)
             {
-                propertyElement.Add(new XElement(prop.Key), prop.Value);
+                propertyElement.Add(new XElement(prop.Key, prop.Value));
             }
         }