Modernize - Ran many openrewrite recipes

retrodaredevil · retrodaredevil · commit 0d792e09c3a6 · 2026-03-15T20:56:50.000-06:00
diff --git a/action-node/src/main/java/me/retrodaredevil/action/node/expression/type/PrimitiveExpressionType.java b/action-node/src/main/java/me/retrodaredevil/action/node/expression/type/PrimitiveExpressionType.java
@@ -7,5 +7,5 @@ public enum PrimitiveExpressionType implements ExpressionType {
 	NUMERIC,
 	STRING,
 	BOOLEAN,
-	;
+	
 }
diff --git a/buildSrc/src/main/kotlin/buildlogic.java-common-conventions.gradle.kts b/buildSrc/src/main/kotlin/buildlogic.java-common-conventions.gradle.kts
@@ -234,9 +234,71 @@ rewrite {
 	// https://docs.openrewrite.org/recipes/java/shortenfullyqualifiedtypereferences
 	activeRecipe("org.openrewrite.java.ShortenFullyQualifiedTypeReferences")
 
+//	activeRecipe("org.openrewrite.java.migrate.util.SequencedCollection") // TODO this was enabled, but it won't compile for all language versions
+	activeRecipe("org.openrewrite.java.migrate.lang.SwitchCaseAssignmentsToSwitchExpression")
+	activeRecipe("org.openrewrite.java.migrate.lang.SwitchCaseReturnsToSwitchExpression")
+	activeRecipe("org.openrewrite.java.jspecify.MigrateToJSpecify") // probably not necessary, but will point out "wrong" nullability imports
+	activeRecipe("org.openrewrite.java.ShortenFullyQualifiedTypeReferences")
+
 	// Lots of static analysis
-//	activeRecipe("org.openrewrite.staticanalysis.RemoveExtraSemicolons")
+	activeRecipe("org.openrewrite.staticanalysis.RemoveExtraSemicolons")
 	activeRecipe("org.openrewrite.staticanalysis.AnnotateNullableParameters") // if you check for null, it should be @Nullable
+	activeRecipe("org.openrewrite.staticanalysis.CatchClauseOnlyRethrows")
+	activeRecipe("org.openrewrite.staticanalysis.CompareEnumsWithEqualityOperator")
+//	activeRecipe("org.openrewrite.staticanalysis.FinalClass") // maybe consider in the future
+	activeRecipe("org.openrewrite.staticanalysis.ForLoopIncrementInUpdate")
+//	activeRecipe("org.openrewrite.staticanalysis.UpperCaseLiteralSuffixes") // eventually maybe we can consider this
+//	activeRecipe("org.openrewrite.staticanalysis.UseDiamondOperator") // TODO see what this does independently
+	activeRecipe("org.openrewrite.staticanalysis.BooleanChecksNotInverted")
+//	activeRecipe("org.openrewrite.staticanalysis.NeedBraces") // consider in the future
+//	activeRecipe("org.openrewrite.staticanalysis.HideUtilityClassConstructor") // tries to make spring application class have private constructor
+//	activeRecipe("org.openrewrite.staticanalysis.JavaApiBestPractices") // TODO enable
+	activeRecipe("org.openrewrite.staticanalysis.ModifierOrder")
+	activeRecipe("org.openrewrite.staticanalysis.NestedEnumsAreNotStatic")
+	activeRecipe("org.openrewrite.staticanalysis.UseJavaStyleArrayDeclarations")
+	activeRecipe("org.openrewrite.staticanalysis.NoDoubleBraceInitialization")
+//	activeRecipe("org.openrewrite.staticanalysis.MultipleVariableDeclarations") // maybe consider in the future
+//	activeRecipe("org.openrewrite.staticanalysis.OperatorWrap") // TODO enable - this is a good thing, but results in many many changes
+	activeRecipe("org.openrewrite.staticanalysis.PreferSystemGetPropertyOverGetenv")
+	activeRecipe("org.openrewrite.staticanalysis.PreferEqualityComparisonOverDifferenceCheck")
+	activeRecipe("org.openrewrite.staticanalysis.PreferIncrementOperator")
+//	activeRecipe("org.openrewrite.staticanalysis.CommonDeclarationSiteTypeVariances") // Could be useful, but honestly the `? super asdf` and `? extends asdf` gets old when it's unnecessary
+	activeRecipe("org.openrewrite.staticanalysis.UnnecessaryPrimitiveAnnotations")
+	activeRecipe("org.openrewrite.staticanalysis.UnnecessaryCatch")
+	activeRecipe("org.openrewrite.staticanalysis.EmptyBlock")
+//	activeRecipe("org.openrewrite.staticanalysis.RemoveRedundantTypeCast") // bug where it will sometimes remove (T) in unchecked code
+	activeRecipe("org.openrewrite.staticanalysis.RemoveRedundantNullCheckBeforeInstanceof")
+	activeRecipe("org.openrewrite.staticanalysis.RemoveRedundantNullCheckBeforeLiteralEquals")
+	activeRecipe($$"org.openrewrite.staticanalysis.SimplifyTernaryRecipes$SimplifyTernaryFalseTrueRecipe")
+	activeRecipe($$"org.openrewrite.staticanalysis.SimplifyTernaryRecipes$SimplifyTernaryTrueFalseRecipe")
+	activeRecipe("org.openrewrite.staticanalysis.UseListSort")
+	activeRecipe("org.openrewrite.staticanalysis.SimplifyBooleanExpression")
+	activeRecipe("org.openrewrite.staticanalysis.SimplifyBooleanReturn")
+	activeRecipe("org.openrewrite.staticanalysis.StaticMethodNotFinal")
+	activeRecipe("org.openrewrite.staticanalysis.NoToStringOnStringType")
+	activeRecipe("org.openrewrite.staticanalysis.UnnecessaryCloseInTryWithResources")
+	activeRecipe("org.openrewrite.staticanalysis.UnnecessaryExplicitTypeArguments")
+	activeRecipe("org.openrewrite.staticanalysis.UnnecessaryReturnAsLastStatement")
+	activeRecipe("org.openrewrite.staticanalysis.UnnecessaryThrows")
+	activeRecipe("org.openrewrite.staticanalysis.UnwrapRepeatableAnnotations")
+//	activeRecipe("org.openrewrite.staticanalysis.UnwrapElseAfterReturn") // kinda annoying when I want to pick the style on a per if-else statement basis
+	activeRecipe("org.openrewrite.staticanalysis.UsePortableNewlines")
+//	activeRecipe("org.openrewrite.staticanalysis.UseCollectionInterfaces") // stops people from using something like an ArrayList in a return type // TODO enable
+//	activeRecipe("org.openrewrite.staticanalysis.IsEmptyCallOnCollections") // eventually enable this, but first update some tests
+	activeRecipe("org.openrewrite.staticanalysis.NoEmptyCollectionWithRawType")
+	activeRecipe("org.openrewrite.staticanalysis.ReplaceCollectionToArrayArgWithEmptyArray")
+	activeRecipe("org.openrewrite.staticanalysis.UseMapContainsKey")
+	activeRecipe("org.openrewrite.staticanalysis.UseStandardCharset")
+	activeRecipe("org.openrewrite.staticanalysis.EqualsToContentEquals")
+	activeRecipe("org.openrewrite.staticanalysis.StringLiteralEquality")
+	activeRecipe("org.openrewrite.staticanalysis.UseStringReplace")
+	activeRecipe("org.openrewrite.staticanalysis.UseSystemLineSeparator")
+	activeRecipe("org.openrewrite.staticanalysis.NoEqualityInForCondition")
+	// consider https://docs.openrewrite.org/recipes/staticanalysis/explicitlambdaargumenttypes later
+	activeRecipe("org.openrewrite.staticanalysis.IndexOfChecksShouldUseAStartPosition")
+	activeRecipe("org.openrewrite.staticanalysis.PrimitiveWrapperClassConstructorToValueOf")
+	activeRecipe("org.openrewrite.staticanalysis.RemoveHashCodeCallsFromArrayInstances")
+	activeRecipe("org.openrewrite.staticanalysis.IndexOfReplaceableByContains")
+	activeRecipe("org.openrewrite.staticanalysis.BigDecimalDoubleConstructorRecipe")
 
-	// TODO add more
 }
diff --git a/client/src/main/java/me/retrodaredevil/solarthing/actions/chatbot/SlackChatBotAction.java b/client/src/main/java/me/retrodaredevil/solarthing/actions/chatbot/SlackChatBotAction.java
@@ -178,9 +178,9 @@ private void handle(EventsApiEnvelope eventsApiEnvelope) {
 		}
 	}
 	private static Instant epochSecondsToInstant(BigDecimal timestampBigDecimal) {
-		long nanos = timestampBigDecimal.multiply(new BigDecimal(1_000_000)).remainder(new BigDecimal(1000)).longValue() * 1000;
+		long nanos = timestampBigDecimal.multiply(BigDecimal.valueOf(1_000_000)).remainder(BigDecimal.valueOf(1000)).longValue() * 1000;
 		// convert epoch millis to milliseconds, then add additional nanoseconds
-		return Instant.ofEpochMilli(timestampBigDecimal.multiply(new BigDecimal(1000)).longValue())
+		return Instant.ofEpochMilli(timestampBigDecimal.multiply(BigDecimal.valueOf(1000)).longValue())
 				.plusNanos(nanos);
 	}
 
diff --git a/client/src/main/java/me/retrodaredevil/solarthing/program/subprogram/pvoutput/PVOutputHandler.java b/client/src/main/java/me/retrodaredevil/solarthing/program/subprogram/pvoutput/PVOutputHandler.java
@@ -117,17 +117,17 @@ private static boolean isGoodReading(TemperatureCelsiusProvider temperatureCelsi
 		int removeAmount = uniqueReadings.size() / 7 + 1; // remove at least 1 set of outliers. For every 7 unique readings, remove another set
 		for (int i = 0; i < removeAmount; i++) {
 			// remove outliers
-			uniqueReadings.remove(uniqueReadings.first());
+			uniqueReadings.remove(uniqueReadings.getFirst());
 			if (!uniqueReadings.isEmpty()) { // need to make this check because it's possible that the size is 1 before removing the first element
-				uniqueReadings.remove(uniqueReadings.last());
+				uniqueReadings.remove(uniqueReadings.getLast());
 			}
 		}
 		if (uniqueReadings.isEmpty()) {
 			// better safe than sorry
 			return false;
 		}
-		float firstReading = uniqueReadings.first();
-		float lastReading = uniqueReadings.last();
+		float firstReading = uniqueReadings.getFirst();
+		float lastReading = uniqueReadings.getLast();
 		return temperatureCelsius > firstReading - 4.0f && temperatureCelsius < lastReading + 4.0f;
 	}
 	private static AddStatusParametersBuilder createStatusBuilder(ZoneId zoneId, long dateMillis) {
diff --git a/common/src/main/java/me/retrodaredevil/solarthing/actions/mate/ACModeActionNode.java b/common/src/main/java/me/retrodaredevil/solarthing/actions/mate/ACModeActionNode.java
@@ -37,7 +37,7 @@ public ACModeActionNode(ACMode acMode, boolean not) {
 		this.not = not;
 	}
 	private static ACMode parseMode(String modeName) {
-		modeName = modeName.replaceAll(" ", "").toLowerCase(Locale.ENGLISH);
+		modeName = modeName.replace(" ", "").toLowerCase(Locale.ENGLISH);
 		return switch (modeName) {
 			case "noac" -> ACMode.NO_AC;
 			case "acdrop" -> ACMode.AC_DROP;
diff --git a/common/src/main/java/me/retrodaredevil/solarthing/actions/mate/FXOperationalModeActionNode.java b/common/src/main/java/me/retrodaredevil/solarthing/actions/mate/FXOperationalModeActionNode.java
@@ -41,9 +41,9 @@ public static FXOperationalModeActionNode create(@JsonProperty(value = "mode", r
 	}
 	private static OperationalMode parseMode(String modeString) {
 		requireNonNull(modeString);
-		modeString = modeString.replaceAll(" ", "");
+		modeString = modeString.replace(" ", "");
 		for (OperationalMode mode : OperationalMode.values()) {
-			if (mode.getModeName().replaceAll(" ", "").equalsIgnoreCase(modeString)) {
+			if (mode.getModeName().replace(" ", "").equalsIgnoreCase(modeString)) {
 				return mode;
 			}
 		}
diff --git a/core/src/main/java/me/retrodaredevil/solarthing/misc/weather/W1TemperatureListUpdater.java b/core/src/main/java/me/retrodaredevil/solarthing/misc/weather/W1TemperatureListUpdater.java
@@ -44,7 +44,7 @@ public void receive(List<Packet> packets) {
 		long startTimeNanos = System.nanoTime();
 		final String name;
 		try {
-			name = readContents(nameFile).replaceAll("\n", ""); // remove new line at end
+			name = readContents(nameFile).replace("\n", ""); // remove new line at end
 		} catch (FileNotFoundException e){
 			LOGGER.error("name file does not exist. file: " + nameFile);
 			return;
diff --git a/core/src/main/java/me/retrodaredevil/solarthing/util/TimeUtil.java b/core/src/main/java/me/retrodaredevil/solarthing/util/TimeUtil.java
@@ -43,7 +43,7 @@ public static String informalDurationToFormal(String informalDuration) {
 				.replaceAll("MINUTES|MINUTE", "M")
 				.replaceAll("HOURS|HOUR", "H")
 				.replaceAll("DAYS|DAY", "D")
-				.replaceAll("AND", "")
+				.replace("AND", "")
 				;
 		if (!formalDuration.startsWith("P")) { // Make the format of the string we send lenient
 			if (formalDuration.contains("T")) {
@@ -52,7 +52,7 @@ public static String informalDurationToFormal(String informalDuration) {
 				formalDuration = "PT" + formalDuration;
 			}
 		}
-		formalDuration = formalDuration.replaceAll(" ", "");
+		formalDuration = formalDuration.replace(" ", "");
 		return formalDuration;
 	}
 	public static @Nullable Duration lenientParseDurationOrNull(String informalDuration) {
@@ -74,9 +74,9 @@ public static String instantToSlackDateSeconds(Instant instant, String fallback)
 	public static String slackEscape(String messageToEscape) {
 		// https://api.slack.com/reference/surfaces/formatting#escaping
 		return messageToEscape
-				.replaceAll("&", "&amp;")
-				.replaceAll("<", "&lt;")
-				.replaceAll(">", "&gt;")
+				.replace("&", "&amp;")
+				.replace("<", "&lt;")
+				.replace(">", "&gt;")
 				;
 	}
 }
diff --git a/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLBatteryRecordService.java b/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLBatteryRecordService.java
@@ -105,8 +105,8 @@ public SolarThingBatteryEstimate(List<IdentificationCacheDataPacket<BatteryRecor
 			if (data.isEmpty()) {
 				return Collections.emptyList();
 			}
-			var first = data.get(0);
-			var last = data.get(data.size() - 1);
+			var first = data.getFirst();
+			var last = data.getLast();
 
 			int lastFirstIndex = data.size();
 			long lastStartDateMillis = last.getPeriodEndDateMillis();
diff --git a/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLDailyService.java b/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLDailyService.java
@@ -126,14 +126,14 @@ private <T extends Identifiable & DailyData> List<DataNode<Float>> getPoints(Cla
 			return new ArrayList<>(r);
 		}
 		private <T extends DailyData> void addAllPoints(Collection<? super DataNode<Float>> nodesOut, List<TimestampedPacket<T>> timestampedPackets, List<AccumulationPair<T>> accumulationPairs, String sourceId, int fragmentId, Function<T, Float> totalGetter) {
-			T firstPacket = timestampedPackets.get(0).getPacket();
+			T firstPacket = timestampedPackets.getFirst().getPacket();
 			List<AccumulationCalc.SumNode<FloatAccumulationValue>> sumNodes = AccumulationCalc.getTotals(accumulationPairs, FloatAccumulationValue.convert(totalGetter), timestampedPackets, FloatAccumulationValueFactory.getInstance());
 			for (AccumulationCalc.SumNode<FloatAccumulationValue> sumNode : sumNodes) {
 				nodesOut.add(new DataNode<>(sumNode.getSum().getValue(), firstPacket, sumNode.getDateMillis(), sourceId, fragmentId));
 			}
 		}
 		private <T extends DailyData> void addDayPoints(Collection<? super DataNode<Float>> nodesOut, List<TimestampedPacket<T>> timestampedPackets, List<AccumulationPair<T>> accumulationPairs, String sourceId, int fragmentId, long dayStartTimeMillis, Function<T, Float> totalGetter) {
-			T firstPacket = timestampedPackets.get(0).getPacket();
+			T firstPacket = timestampedPackets.getFirst().getPacket();
 			float total = AccumulationCalc.getTotal(accumulationPairs, FloatAccumulationValue.convert(totalGetter), FloatAccumulationValueFactory.getInstance()).getValue();
 			nodesOut.add(new DataNode<>(total, firstPacket, dayStartTimeMillis, sourceId, fragmentId));
 		}
diff --git a/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLFXService.java b/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLFXService.java
@@ -65,7 +65,7 @@ public List<DataNode<FXChargingPacket>> queryFXCharging(
 		);
 		List<FragmentedPacketGroup> sortedPackets = null;
 		for (List<FragmentedPacketGroup> fragmentedPacketGroups : map.values()) {
-			if (fragmentedPacketGroups.get(0).hasFragmentId(fragmentId)) {
+			if (fragmentedPacketGroups.getFirst().hasFragmentId(fragmentId)) {
 				sortedPackets = fragmentedPacketGroups;
 				break;
 			}
diff --git a/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLService.java b/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLService.java
@@ -114,12 +114,12 @@ public SolarThingGraphQLService(SimpleQueryHandler simpleQueryHandler) {
 		List<? extends InstancePacketGroup> packets = simpleQueryHandler.queryStatus(to - SolarThingConstants.LATEST_PACKETS_DURATION.toMillis(), to, sourceId, fragmentId);
 		List<InstancePacketGroup> lastPackets = new ArrayList<>();
 		for(List<InstancePacketGroup> packetGroups : PacketGroups.mapFragments(packets).values()) {
-			lastPackets.add(packetGroups.get(packetGroups.size() - 1));
+			lastPackets.add(packetGroups.getLast());
 		}
 		List<? extends FragmentedPacketGroup> sortedPackets = simpleQueryHandler.sortPackets(lastPackets, sourceId);
 		return new SolarThingStatusQuery(
 				new ReversedPacketGetter(new LastPacketGetter(packets, PacketFilter.KEEP_ALL), reversed),
-				sortedPackets.isEmpty() ? Collections.emptyList() : Collections.singletonList(sortedPackets.get(sortedPackets.size() - 1)),
+				sortedPackets.isEmpty() ? Collections.emptyList() : Collections.singletonList(sortedPackets.getLast()),
 				simpleQueryHandler
 		);
 	}
@@ -374,7 +374,7 @@ public float getACChargeWattage() {
 		}
 		@JsonProperty("acMode")
 		public @NonNull ACMode getACMode() {
-			return fx.get(0).getACMode();
+			return fx.getFirst().getACMode();
 		}
 		@JsonProperty("miscModesString")
 		public @NonNull String getMiscModesString() {
@@ -462,9 +462,9 @@ public FlatData(List<SolarDevice> solarDevice, List<BatteryVoltage> batteryVolta
 		@JsonProperty("batteryVoltage")
 		public @Nullable Float getBatteryVoltage() {
 			// default to prefer first FX battery voltage;
-			BatteryVoltage device = fx.isEmpty() ? null : fx.get(0);
+			BatteryVoltage device = fx.isEmpty() ? null : fx.getFirst();
 			if (device == null) {
-				device = batteryVoltage.isEmpty() ? null : batteryVoltage.get(0);
+				device = batteryVoltage.isEmpty() ? null : batteryVoltage.getFirst();
 			}
 			if (device == null) {
 				return null;
diff --git a/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLSolcastService.java b/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/SolarThingGraphQLSolcastService.java
@@ -133,10 +133,10 @@ public SolarThingSolcastQuery(SolcastHandler handler, long from, long to, ZoneId
 			);
 
 
-			SimpleEstimatedActual first = simpleEstimatedActuals.get(0);
+			SimpleEstimatedActual first = simpleEstimatedActuals.getFirst();
 
 			startDate = max(startDate, first.getPeriodMidpoint().atZone(zoneId).toLocalDate().plusDays(1));
-			SimpleEstimatedActual last = simpleEstimatedActuals.get(simpleEstimatedActuals.size() - 1);
+			SimpleEstimatedActual last = simpleEstimatedActuals.getLast();
 
 			endDate = min(endDate, last.getPeriodMidpoint().atZone(zoneId).toLocalDate().minusDays(1));
 
@@ -207,7 +207,7 @@ public SolarThingSolcastDayQuery(SolcastHandler handler, long to, ZoneId zoneId,
 				}
 			}
 
-			SimpleEstimatedActual lastEstimatedActual = estimatedActuals.isEmpty() ? null : estimatedActuals.get(estimatedActuals.size() - 1);
+			SimpleEstimatedActual lastEstimatedActual = estimatedActuals.isEmpty() ? null : estimatedActuals.getLast();
 
 			float actualDailyKWH = 0;
 			for (IdentificationCacheDataPacket<ChargeControllerAccumulationDataCache> cacheDataPacket : chargeControllerAccumulationCache) {
diff --git a/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/web/DatabaseAuthorization.java b/server/src/main/java/me/retrodaredevil/solarthing/rest/graphql/service/web/DatabaseAuthorization.java
@@ -46,7 +46,7 @@ public static DatabaseAuthorization create(Cookie cookie) {
 
 	@JsonProperty("url") // public to avoid IllegalAccessException in GraphQL-spqr code
 	public @NonNull String getUrlString() {
-		return cookie.domain().toString();
+		return cookie.domain();
 	}
 
 	@JsonProperty("cookie") // public to avoid IllegalAccessException in GraphQL-spqr code

Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,5 @@ public enum PrimitiveExpressionType implements ExpressionType {`
`7`	`7`	`NUMERIC,`
`8`	`8`	`STRING,`
`9`	`9`	`BOOLEAN,`
`10`		`- ;`
	`10`	`+`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -178,9 +178,9 @@ private void handle(EventsApiEnvelope eventsApiEnvelope) {`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`	`private static Instant epochSecondsToInstant(BigDecimal timestampBigDecimal) {`
`181`		`- long nanos = timestampBigDecimal.multiply(new BigDecimal(1_000_000)).remainder(new BigDecimal(1000)).longValue() * 1000;`
	`181`	`+ long nanos = timestampBigDecimal.multiply(BigDecimal.valueOf(1_000_000)).remainder(BigDecimal.valueOf(1000)).longValue() * 1000;`
`182`	`182`	`// convert epoch millis to milliseconds, then add additional nanoseconds`
`183`		`- return Instant.ofEpochMilli(timestampBigDecimal.multiply(new BigDecimal(1000)).longValue())`
	`183`	`+ return Instant.ofEpochMilli(timestampBigDecimal.multiply(BigDecimal.valueOf(1000)).longValue())`
`184`	`184`	`.plusNanos(nanos);`
`185`	`185`	`}`
`186`	`186`
Original file line number	Diff line number	Diff line change
`@@ -117,17 +117,17 @@ private static boolean isGoodReading(TemperatureCelsiusProvider temperatureCelsi`
`117`	`117`	`int removeAmount = uniqueReadings.size() / 7 + 1; // remove at least 1 set of outliers. For every 7 unique readings, remove another set`
`118`	`118`	`for (int i = 0; i < removeAmount; i++) {`
`119`	`119`	`// remove outliers`
`120`		`- uniqueReadings.remove(uniqueReadings.first());`
	`120`	`+ uniqueReadings.remove(uniqueReadings.getFirst());`
`121`	`121`	`if (!uniqueReadings.isEmpty()) { // need to make this check because it's possible that the size is 1 before removing the first element`
`122`		`- uniqueReadings.remove(uniqueReadings.last());`
	`122`	`+ uniqueReadings.remove(uniqueReadings.getLast());`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`	`if (uniqueReadings.isEmpty()) {`
`126`	`126`	`// better safe than sorry`
`127`	`127`	`return false;`
`128`	`128`	`}`
`129`		`- float firstReading = uniqueReadings.first();`
`130`		`- float lastReading = uniqueReadings.last();`
	`129`	`+ float firstReading = uniqueReadings.getFirst();`
	`130`	`+ float lastReading = uniqueReadings.getLast();`
`131`	`131`	`return temperatureCelsius > firstReading - 4.0f && temperatureCelsius < lastReading + 4.0f;`
`132`	`132`	`}`
`133`	`133`	`private static AddStatusParametersBuilder createStatusBuilder(ZoneId zoneId, long dateMillis) {`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public ACModeActionNode(ACMode acMode, boolean not) {`
`37`	`37`	`this.not = not;`
`38`	`38`	`}`
`39`	`39`	`private static ACMode parseMode(String modeName) {`
`40`		`- modeName = modeName.replaceAll(" ", "").toLowerCase(Locale.ENGLISH);`
	`40`	`+ modeName = modeName.replace(" ", "").toLowerCase(Locale.ENGLISH);`
`41`	`41`	`return switch (modeName) {`
`42`	`42`	`case "noac" -> ACMode.NO_AC;`
`43`	`43`	`case "acdrop" -> ACMode.AC_DROP;`
Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,9 @@ public static FXOperationalModeActionNode create(@JsonProperty(value = "mode", r`
`41`	`41`	`}`
`42`	`42`	`private static OperationalMode parseMode(String modeString) {`
`43`	`43`	`requireNonNull(modeString);`
`44`		`- modeString = modeString.replaceAll(" ", "");`
	`44`	`+ modeString = modeString.replace(" ", "");`
`45`	`45`	`for (OperationalMode mode : OperationalMode.values()) {`
`46`		`- if (mode.getModeName().replaceAll(" ", "").equalsIgnoreCase(modeString)) {`
	`46`	`+ if (mode.getModeName().replace(" ", "").equalsIgnoreCase(modeString)) {`
`47`	`47`	`return mode;`
`48`	`48`	`}`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public static String informalDurationToFormal(String informalDuration) {`
`43`	`43`	`.replaceAll("MINUTES\|MINUTE", "M")`
`44`	`44`	`.replaceAll("HOURS\|HOUR", "H")`
`45`	`45`	`.replaceAll("DAYS\|DAY", "D")`
`46`		`- .replaceAll("AND", "")`
	`46`	`+ .replace("AND", "")`
`47`	`47`	`;`
`48`	`48`	`if (!formalDuration.startsWith("P")) { // Make the format of the string we send lenient`
`49`	`49`	`if (formalDuration.contains("T")) {`
`@@ -52,7 +52,7 @@ public static String informalDurationToFormal(String informalDuration) {`
`52`	`52`	`formalDuration = "PT" + formalDuration;`
`53`	`53`	`}`
`54`	`54`	`}`
`55`		`- formalDuration = formalDuration.replaceAll(" ", "");`
	`55`	`+ formalDuration = formalDuration.replace(" ", "");`
`56`	`56`	`return formalDuration;`
`57`	`57`	`}`
`58`	`58`	`public static @Nullable Duration lenientParseDurationOrNull(String informalDuration) {`
`@@ -74,9 +74,9 @@ public static String instantToSlackDateSeconds(Instant instant, String fallback)`
`74`	`74`	`public static String slackEscape(String messageToEscape) {`
`75`	`75`	`// https://api.slack.com/reference/surfaces/formatting#escaping`
`76`	`76`	`return messageToEscape`
`77`		`- .replaceAll("&", "&")`
`78`		`- .replaceAll("<", "<")`
`79`		`- .replaceAll(">", ">")`
	`77`	`+ .replace("&", "&")`
	`78`	`+ .replace("<", "<")`
	`79`	`+ .replace(">", ">")`
`80`	`80`	`;`
`81`	`81`	`}`
`82`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -126,14 +126,14 @@ private <T extends Identifiable & DailyData> List<DataNode<Float>> getPoints(Cla`
`126`	`126`	`return new ArrayList<>(r);`
`127`	`127`	`}`
`128`	`128`	`private <T extends DailyData> void addAllPoints(Collection<? super DataNode<Float>> nodesOut, List<TimestampedPacket<T>> timestampedPackets, List<AccumulationPair<T>> accumulationPairs, String sourceId, int fragmentId, Function<T, Float> totalGetter) {`
`129`		`- T firstPacket = timestampedPackets.get(0).getPacket();`
	`129`	`+ T firstPacket = timestampedPackets.getFirst().getPacket();`
`130`	`130`	`List<AccumulationCalc.SumNode<FloatAccumulationValue>> sumNodes = AccumulationCalc.getTotals(accumulationPairs, FloatAccumulationValue.convert(totalGetter), timestampedPackets, FloatAccumulationValueFactory.getInstance());`
`131`	`131`	`for (AccumulationCalc.SumNode<FloatAccumulationValue> sumNode : sumNodes) {`
`132`	`132`	`nodesOut.add(new DataNode<>(sumNode.getSum().getValue(), firstPacket, sumNode.getDateMillis(), sourceId, fragmentId));`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`	`private <T extends DailyData> void addDayPoints(Collection<? super DataNode<Float>> nodesOut, List<TimestampedPacket<T>> timestampedPackets, List<AccumulationPair<T>> accumulationPairs, String sourceId, int fragmentId, long dayStartTimeMillis, Function<T, Float> totalGetter) {`
`136`		`- T firstPacket = timestampedPackets.get(0).getPacket();`
	`136`	`+ T firstPacket = timestampedPackets.getFirst().getPacket();`
`137`	`137`	`float total = AccumulationCalc.getTotal(accumulationPairs, FloatAccumulationValue.convert(totalGetter), FloatAccumulationValueFactory.getInstance()).getValue();`
`138`	`138`	`nodesOut.add(new DataNode<>(total, firstPacket, dayStartTimeMillis, sourceId, fragmentId));`
`139`	`139`	`}`