Merge pull request #11 from riptideslabs/multi-loop-fix

werbenhu · web-flow · commit 2aa8fbd99ada · 2025-09-06T11:58:46.000+08:00
Remove second goroutine for channel loop in Publish and PublishSync methods
diff --git a/eventbus.go b/eventbus.go
@@ -209,7 +209,6 @@ func (e *EventBus) Publish(topic string, payload any) error {
 	if !ok {
 		ch = newChannel(topic, e.bufferSize)
 		e.channels.Store(topic, ch)
-		go ch.(*channel).loop()
 	}
 
 	return ch.(*channel).publish(payload)
@@ -224,7 +223,6 @@ func (e *EventBus) PublishSync(topic string, payload any) error {
 	if !ok {
 		ch = newChannel(topic, e.bufferSize)
 		e.channels.Store(topic, ch)
-		go ch.(*channel).loop()
 	}
 
 	return ch.(*channel).publishSync(payload)

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,6 @@ func (e *EventBus) Publish(topic string, payload any) error {`
`209`	`209`	`if !ok {`
`210`	`210`	`ch = newChannel(topic, e.bufferSize)`
`211`	`211`	`e.channels.Store(topic, ch)`
`212`		`- go ch.(*channel).loop()`
`213`	`212`	`}`
`214`	`213`
`215`	`214`	`return ch.(*channel).publish(payload)`
`@@ -224,7 +223,6 @@ func (e *EventBus) PublishSync(topic string, payload any) error {`
`224`	`223`	`if !ok {`
`225`	`224`	`ch = newChannel(topic, e.bufferSize)`
`226`	`225`	`e.channels.Store(topic, ch)`
`227`		`- go ch.(*channel).loop()`
`228`	`226`	`}`
`229`	`227`
`230`	`228`	`return ch.(*channel).publishSync(payload)`