refactor: update shellcheck directives for improved script validation and maintain consistency in source paths across command and test scripts

Author: MichaelAndish

src/commands/init.sh

@@ -22,6 +22,7 @@ source "$FLOWAI_HOME/src/os/platform.sh"
 # are available during the wizard without hardcoding tool names.
 for _init_tool_plugin in "$FLOWAI_HOME/src/tools/"*.sh; do
   [[ -f "$_init_tool_plugin" ]] || continue
+  # shellcheck source=/dev/null  # dynamic plugin path — intentional
   source "$_init_tool_plugin"
 done
 unset _init_tool_plugin

src/commands/logs.sh

@@ -6,9 +6,9 @@
 
 set -euo pipefail
 
-# shellcheck source=../core/log.sh
+# shellcheck source=src/core/log.sh
 source "$FLOWAI_HOME/src/core/log.sh"
-# shellcheck source=../core/session.sh
+# shellcheck source=src/core/session.sh
 source "$FLOWAI_HOME/src/core/session.sh"
 
 if ! command -v tmux >/dev/null 2>&1; then

src/commands/models.sh

@@ -42,6 +42,7 @@ declare -a available_tools=()
 if [[ -d "$FLOWAI_HOME/src/tools" ]]; then
   for tool_file in "$FLOWAI_HOME/src/tools/"*.sh; do
     [[ -f "$tool_file" ]] || continue
+    # shellcheck source=/dev/null  # dynamic plugin path — intentional
     source "$tool_file"
     tool_name="$(basename "$tool_file" .sh)"
     available_tools+=("$tool_name")

src/core/config-validate.sh

@@ -4,7 +4,7 @@
 
 # shellcheck source=src/core/log.sh
 source "$FLOWAI_HOME/src/core/log.sh"
-# shellcheck source=models-catalog.sh
+# shellcheck source=src/core/models-catalog.sh
 [[ -n "${FLOWAI_HOME:-}" ]] && source "$FLOWAI_HOME/src/core/models-catalog.sh"
 
 # Check one (tool, model) pair. Returns 0 if ok or empty; 1 if invalid (strict).

src/core/config.sh

@@ -5,7 +5,7 @@
 export FLOWAI_DIR="${FLOWAI_DIR:-$PWD/.flowai}"
 export FLOWAI_CONFIG="${FLOWAI_DIR}/config.json"
 
-# shellcheck source=models-catalog.sh
+# shellcheck source=src/core/models-catalog.sh
 [[ -n "${FLOWAI_HOME:-}" ]] && source "$FLOWAI_HOME/src/core/models-catalog.sh"
 
 # Reject absolute paths and ".." segments so stored paths cannot escape $PWD at read time.

tests/suites/ai_resolution.sh

@@ -3,6 +3,7 @@
 # Tests for flowai_ai_resolve_model_for_tool, flowai_ai_resolve_tool_and_model_for_phase,
 # and flowai_ai_tool_is_paste_only in src/core/ai.sh.
 # shellcheck shell=bash
+# shellcheck disable=SC2016  # bash -c strings use $ vars for inner shell, not outer
 #
 # Isolated temp projects use: env FLOWAI_DIR=… FLOWAI_HOME=… bash -s <<'EOS' … EOS
 # so ShellCheck does not treat exports as lost subshell assignments (SC2030/SC2031).

tests/suites/graph_edge_cases.sh

@@ -13,6 +13,7 @@
 #
 # Expects tests/lib/harness.sh sourced first (see tests/run.sh).
 # shellcheck shell=bash
+# shellcheck disable=SC2016  # tests use single-quoted bash -c with $ vars intentionally
 
 source "$FLOWAI_HOME/src/core/log.sh"
 

tests/suites/logs_command.sh

@@ -2,6 +2,7 @@
 # Logs command — tests for src/commands/logs.sh
 # Expects tests/lib/harness.sh sourced first (see tests/run.sh).
 # shellcheck shell=bash
+# shellcheck disable=SC2016  # grep patterns contain $ for literal matching, not shell expansion
 
 # shellcheck source=../../src/core/log.sh
 source "$FLOWAI_HOME/src/core/log.sh"

tests/suites/master_orchestration.sh

@@ -5,6 +5,7 @@
 # runs interactive AI sessions), so we do NOT source it. Tests use grep/pattern
 # analysis on the source file or validate extracted regex patterns inline.
 # shellcheck shell=bash
+# shellcheck disable=SC2016  # grep patterns match literal $ in source files
 
 # shellcheck source=../../src/core/log.sh
 source "$FLOWAI_HOME/src/core/log.sh"

tests/suites/orchestration_extended.sh

@@ -3,6 +3,7 @@
 # phase timeout / pre-signal fast path, feature directory resolution,
 # constraint reminder constant, and tool plugin API completeness.
 # shellcheck shell=bash
+# shellcheck disable=SC2016  # bash -c strings use $ vars for inner shell, not outer
 
 # shellcheck source=../../src/core/log.sh
 source "$FLOWAI_HOME/src/core/log.sh"