From 98a3dd8f5457f2b343fe9593360ee2255a0ea333 Mon Sep 17 00:00:00 2001 From: func0der <529819+func0der@users.noreply.github.com> Date: Mon, 1 Jun 2026 10:39:32 +0200 Subject: [PATCH 1/3] fix-php85-deprecation-notice Use new constant in php 8.4 or higher to avoid deprecation notices --- src/Webfactory/Slimdump/Database/Dumper.php | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/Webfactory/Slimdump/Database/Dumper.php b/src/Webfactory/Slimdump/Database/Dumper.php index e3365cf..2b22b80 100644 --- a/src/Webfactory/Slimdump/Database/Dumper.php +++ b/src/Webfactory/Slimdump/Database/Dumper.php @@ -14,6 +14,8 @@ use Symfony\Component\Console\Output\OutputInterface; use Webfactory\Slimdump\Config\Table; +use function phpversion; + class Dumper { /** @@ -134,7 +136,7 @@ private function dumpData(Schema\Table $asset, Table $tableConfig): void } else { throw new RuntimeException('failed to obtain the wrapped PDO object from the DBAL connection'); } - $pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, false); + $this->controlBufferedQuery($pdo, false); $actualRows = 0; $this->outputFormatDriver->beginTableDataDump($asset, $tableConfig); @@ -155,7 +157,7 @@ private function dumpData(Schema\Table $asset, Table $tableConfig): void $this->progressOutput->writeln(\sprintf('Expected %d rows, actually processed %d – verify results!', $numRows, $actualRows)); } - $pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true); + $this->controlBufferedQuery($pdo, true); $this->outputFormatDriver->endTableDataDump($asset, $tableConfig); } @@ -166,4 +168,14 @@ public static function isBlob(Schema\Column $column): bool return $type instanceof BlobType || $type instanceof BinaryType; } + + private function controlBufferedQuery(PDO $pdo, bool $value): void + { + if (version_compare(phpversion(), '8.4.0', '<')) { + $pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true); + return; + } + + $pdo->setAttribute(PDO\Mysql::ATTR_USE_BUFFERED_QUERY, $value); + } } From 7ab8cb8bb3354b88215f748d09e6a5325289429e Mon Sep 17 00:00:00 2001 From: func0der <529819+func0der@users.noreply.github.com> Date: Mon, 1 Jun 2026 10:56:20 +0200 Subject: [PATCH 2/3] fix-php85-deprecation-notice Allowlist php8.4 class --- .composer-require-checker.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.composer-require-checker.json b/.composer-require-checker.json index 3cce1e9..316d7f0 100644 --- a/.composer-require-checker.json +++ b/.composer-require-checker.json @@ -2,6 +2,7 @@ "symbol-whitelist": [ "Doctrine\\Common\\EventSubscriber", "Doctrine\\DBAL\\Event\\SchemaColumnDefinitionEventArgs", - "Doctrine\\DBAL\\Events" + "Doctrine\\DBAL\\Events", + "PDO\\Mysql" ] } From 5592f614f86db37a1ab4aaa95d441bc154cf015d Mon Sep 17 00:00:00 2001 From: func0der <529819+func0der@users.noreply.github.com> Date: Mon, 1 Jun 2026 11:02:51 +0200 Subject: [PATCH 3/3] fix-php85-deprecation-notice Use constant instead of function call --- src/Webfactory/Slimdump/Database/Dumper.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Webfactory/Slimdump/Database/Dumper.php b/src/Webfactory/Slimdump/Database/Dumper.php index 2b22b80..35dce8c 100644 --- a/src/Webfactory/Slimdump/Database/Dumper.php +++ b/src/Webfactory/Slimdump/Database/Dumper.php @@ -14,8 +14,6 @@ use Symfony\Component\Console\Output\OutputInterface; use Webfactory\Slimdump\Config\Table; -use function phpversion; - class Dumper { /** @@ -171,8 +169,9 @@ public static function isBlob(Schema\Column $column): bool private function controlBufferedQuery(PDO $pdo, bool $value): void { - if (version_compare(phpversion(), '8.4.0', '<')) { + if (version_compare(\PHP_VERSION, '8.4.0', '<')) { $pdo->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true); + return; }