Skip to content

Commit 8e3f9d1

Browse files
IsaDCmcking65
andauthored
Refactor Test Plan for the Minimal Data Grid Example v2 (pull #1353)
* Add refactored test plan * Remove version 1 * Editorial changes to assertions.csv * Correct assertions.csv * Editorial changes to tests instructions in tests.csv * Remove tests for navigating to cells containing links * Remove setupScripts for focusing cells containing links * Correct voiceover_macos-commands.csv * Generate .html source files with scripts automatically * Correct typo in test 1 * Merge tests 1-3 and 2-4 * Relocate starting point for tests related to navigating withing the grid * Editorial corrections to assertions.csv * Generate .html source files with scripts automatically * Remove unused assertions from assertions.csv * Remove unused setupScript files * Generate .html source files with scripts automatically * Add missing references to references.csv and link them to assertions in assertions.csv * Add interaction mode assertion to assertions.csv for tests 1 and 2 * Correct typo in test 1 * Correct assertions for navigating forwards and backwards into a grid using tab and shift+tab * Correct JAWS commands for navigating forwards into a grid * Set priority for grid boundary to may * Add up arrow for navigating backwards into a grid with JAWS and NVDA * Assert gridBoundary for up arrow only when navigating backwards into a grid * Update assertion to reflect the name of the link * Replace the word coordinates with the word position, for consistency with other test plans * Correct assertions for shift+t and shift+tab in test 2 for all ATs * Correct VoiceOver command to shift+y in test 5 * Except cell position for ins+up for requesting information about a grid cell in JAWS and NVDA commands * Correct VoiceOver commands for navigating backwards into a grid and navigating to the next and previous column * Correct presentation numbers for VoiceOver commands * Test 2: Revise assertions and assertion exceptions for shift+t * Added row1 col1 position assertion to test 2 with 0 priority * Changed assertion exceptions for shift+t so the assertions match 't' command from test 1. In both cases, the reading cursor goes to row 1/col 1. * Editorial revisions to assertions Removed the words 'first' and 'last' from assertion text. * Chantge assertionId firstCellContent01Jan16 to cellContent01Jan16 * Correct assertionId error in test 2 created by prior commit to change shift+t assertions * Change assertionId lastColumnHeaderContentBalance to columnHeaderContentBalance * Change assertionId firstColumnHeaderContentDate to columnHeaderContentDate * Change assertionID coordinatesFirstCellColumn1Row2 to coordinatesCellColumn1Row2 * Change assertionId coordinatesLastCellColumn5Row7 to coordinatesCellColumn5Row7 * Change assertionId lastCellContent99553200 to cellContent99553200 * Change assertionId cellContentHotCoffee to nameLinkHotCoffee * Change assertionId nameTransactionsJanuary1ThroughJanuary6 to nameGrid * Update references * One more ref update * Change assertion priority for arrow commands when navigating backward into a grid (test 2) * Correct assertionId for nameGrid in test 2 assertion exceptions * Revise assertion exceptions for insert+up in test 3 * Replace coordinate assertion with row number and column number assertions for up arrow commands in test 2 In test 2, when navigating backward into a grid with arrow key commands, assert only the row number should be conveyed, make conveying column number optional. For up arrow commands: * remove assertion coordinatesCellColumn5Row7 * Add new assertion rowNumber7 with priority 2 * Add new assertion columnNumber5 with priority 3 * Also reduce priority to 3 for assertions for nameGrid and number of rows and number of columns. * Revise column and row number assertions Replace cell coordinate assertions that combined rolw and col into a single assertion with separate assertions for row number and column number. * Fix row and coll number assertion priorities The assertion exceptions in the JAWS, NVDA, and VO commands specified priority 1 instead of priority 2 for some row and column number assertions. * More fixes to priority of row and col assertion priorities Changed more assertion exceptions to reduce priority of row and col number assertions from 1 to 2. * Add missing row number assertion to test 2 * Change row and col number assertion priorities when testing commands for navigating inside the grid If navigating across a row, e.g., nav to next column, lower priority of the row number assertion to 3. Conversely, if navigating up/down a column, reduce the priority of the column number assertion to 3. * Correct VO next and previous column commands The VoiceOver commands for next and previous column include the quick nav setting so removed the ctrl+opt+cmd modifiers. * Correct VO settings for arrow commands For the left/right/up/down arrows, corrected the VO settings to be arrowQuickKeyNavOff instead of singleQuickKeyNavOff. --------- Co-authored-by: Matt King <a11yThinker@gmail.com>
1 parent 46ef988 commit 8e3f9d1

22 files changed

Lines changed: 140 additions & 954 deletions
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
assertionId,priority,assertionStatement,assertionPhrase,refIds
2+
cellContent01Jan16,1,"Content of the cell, '01-Jan-16', is conveyed","convey content of the cell, '01-Jan-16'",td
3+
cellContent03Jan16,1,"Content of the cell, '03-Jan-16', is conveyed","convey content of the cell, '03-Jan-16'",td
4+
cellContent2500,1,"Content of the cell, '$250.00', is conveyed","convey content of the cell, '$250.00'",td
5+
cellContent8800,1,"Content of the cell, '$88.00', is conveyed","convey content of the cell, '$88.00'",td
6+
cellContent99553200,1,"Content of the cell, '$995,532.00', is conveyed","convey content of the cell, '$995,532.00'",td
7+
cellContent99974100,1,"Content of the cell, '$999,741.00', is conveyed","convey content of the cell, '$999,741.00'",td
8+
columnHeaderContentBalance,1,"Content of the column header, 'Balance', is conveyed","convey content of the column header, 'Balance'",th
9+
columnHeaderContentDate,1,"Content of the column header, 'Date', is conveyed","convey content of the column header, 'Date'",th
10+
columnHeaderContentDescription,1,"Content of the column header, 'Description', is conveyed","convey content of the column header, 'Description'",th
11+
columnNumber1,2,"Column number of the cell, '1', is conveyed","convey column number of the cell, '1'",aria-colindex
12+
columnNumber3,2,"Column number of the cell, '3', is conveyed","convey column number of the cell, '3'",aria-colindex
13+
columnNumber4,2,"Column number of the cell, '4', is conveyed","convey column number of the cell, '4'",aria-colindex
14+
columnNumber5,2,"Column number of the cell, '5', is conveyed","convey column number of the cell, '5'",aria-colindex
15+
rowNumber1,2,"Row number of the cell, '1', is conveyed","convey row number of the cell, '1'",aria-rowindex
16+
rowNumber2,2,"Row number of the cell, '2', is conveyed","convey row number of the cell, '2'",aria-rowindex
17+
rowNumber3,2,"Row number of the cell, '3', is conveyed","convey row number of the cell, '3'",aria-rowindex
18+
rowNumber4,2,"Row number of the cell, '4', is conveyed","convey row number of the cell, '4'",aria-rowindex
19+
rowNumber5,2,"Row number of the cell, '5', is conveyed","convey row number of the cell, '5'",aria-rowindex
20+
rowNumber7,2,"Row number of the cell, '7', is conveyed","convey row number of the cell, '7'",aria-rowindex
21+
gridBoundary,3,Grid boundary is conveyed,convey grid boundary,grid
22+
interactionModeEnabled,2,Screen reader switched from reading mode to interaction mode|{screenReader} switched from {readingMode} to {interactionMode},switch from reading mode to interaction mode|switch from {readingMode} to {interactionMode},grid
23+
nameGrid,1,"Name of the grid, 'Transactions January 1 through January 6', is conveyed","convey name of the grid, 'Transactions January 1 through January 6'",aria-labelledby
24+
nameLinkHotCoffee,1,"Name of the link, 'Hot Coffee', is conveyed","convey name of the link, 'Hot Coffee'",htmlLink
25+
numberColumns5,2,"Number of columns, '5', is conveyed","convey number of columns, '5'",aria-colcount
26+
numberRows7,2,"Number of rows, '7', is conveyed","convey number of rows, '7'",aria-rowcount
27+
roleGrid,1,Role 'grid' is conveyed,convey role 'grid',grid
28+
roleLink,1,Role 'link' is conveyed,convey role 'link',htmlLink

tests/apg/minimal-data-grid/data/commands.csv

Lines changed: 0 additions & 91 deletions
This file was deleted.
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
testId,command,settings,assertionExceptions,presentationNumber
2+
navForwardsToGrid,t,virtualCursor,,1
3+
navForwardsToGrid,down down,virtualCursor,,1.1
4+
navForwardsToGrid,tab,virtualCursor,0:rowNumber1 2:rowNumber2 1:cellContent01Jan16 2:interactionModeEnabled,1.2
5+
navForwardsToGrid,tab,pcCursor,0:rowNumber1 2:rowNumber2 1:cellContent01Jan16,1.3
6+
navBackToGrid,shift+t,virtualCursor,0:columnHeaderContentBalance 0:cellContent99553200 0:columnNumber5 0:rowNumber7 2:columnNumber1 2:rowNumber1 1:columnHeaderContentDate,2
7+
navBackToGrid,up up,virtualCursor,1:gridBoundary 3:nameGrid 3:numberColumns5 3:numberRows7 2:columnHeaderContentBalance,2.1
8+
navBackToGrid,shift+tab,virtualCursor,0:columnHeaderContentBalance 0:cellContent99553200 0:columnNumber5 0:rowNumber7 2:columnNumber1 2:rowNumber2 1:columnHeaderContentDate 1:cellContent01Jan16 2:interactionModeEnabled,2.2
9+
navBackToGrid,shift+tab,pcCursor,0:columnHeaderContentBalance 0:cellContent99553200 0:columnNumber5 0:rowNumber7 2:columnNumber1 2:rowNumber2 1:columnHeaderContentDate 1:cellContent01Jan16,2.3
10+
reqInfoAboutGridCell,ins+tab,virtualCursor,,12
11+
reqInfoAboutGridCell,ins+up,virtualCursor,3:columnHeaderContentDate 3:columnNumber1 3:rowNumber2,12.1
12+
reqInfoAboutGridCell,ins+tab,pcCursor,,12.2
13+
reqInfoAboutGridCell,ins+up,pcCursor,3:columnHeaderContentDate 3:columnNumber1 3:rowNumber2,12.3
14+
navToNextColumnGrid,ctrl+alt+right,virtualCursor,,18
15+
navToNextColumnGrid,right,pcCursor,,19
16+
navToPrevColumnGrid,ctrl+alt+left,virtualCursor,,21
17+
navToPrevColumnGrid,left,pcCursor,,22
18+
navToNextRowGrid,ctrl+alt+down,virtualCursor,,36
19+
navToNextRowGrid,down,pcCursor,,37
20+
navToPrevRowGrid,ctrl+alt+up,virtualCursor,,39
21+
navToPrevRowGrid,up,pcCursor,,40
22+
navToFirstCellRowGrid,home,pcCursor,,48
23+
navToLastCellRowGrid,end,pcCursor,,50
24+
navToFirstCellGrid,ctrl+home,pcCursor,,52
25+
navToLastCellGrid,ctrl+end,pcCursor,,54

tests/apg/minimal-data-grid/data/js/setFocusOnFifthDataCell.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/apg/minimal-data-grid/data/js/setFocusOnFirstLinkedCell.js

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
// sets focus on the fourth cell of the second row in the grid
2-
testPageDocument.defaultView.ex1Grid.setFocusPointer(0, 3);
3-
testPageDocument.defaultView.ex1Grid.focusCell(0, 3);
1+
// sets focus on the fourth cell of the fourth row in the grid
2+
testPageDocument.defaultView.ex1Grid.setFocusPointer(2, 3);
3+
testPageDocument.defaultView.ex1Grid.focusCell(2, 3);

tests/apg/minimal-data-grid/data/js/setFocusOnLastDataCell.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/apg/minimal-data-grid/data/js/setFocusOnSecondDataCell.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/apg/minimal-data-grid/data/js/setFocusOnSecondLinkedCell.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

tests/apg/minimal-data-grid/data/js/setFocusOnSixthDataCell.js

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)