Commit 998779e
committed
refactor(config): drop replaceNullWithEmpty workaround
Address PR review from lxcmyf (2026-04-22, NodeConfig.java:370).
The `replaceNullWithEmpty` helper was originally a compatibility shim for
system-test configs that write `discovery.external.ip = null`. Rather than
generalizing the shim over all paths (the reviewer's concern), remove it
entirely and let ConfigBeanFactory fail fast on HOCON null values.
The auto-binding itself is the right safety net: any String-typed field that
receives `= null` from an external config surfaces at startup as
`ConfigBeanFactory.ValidationFailed` naming the exact path. That's the
correct long-term signal that the external config needs to use `""` or
remove the key, not to be papered over.
No in-repo configs write `= null`; external configs (system-test) should
update their own defaults.1 parent f7bd20f commit 998779e
1 file changed
Lines changed: 3 additions & 18 deletions
Lines changed: 3 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
362 | 362 | | |
363 | 363 | | |
364 | 364 | | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
373 | 368 | | |
374 | 369 | | |
375 | 370 | | |
| |||
500 | 495 | | |
501 | 496 | | |
502 | 497 | | |
503 | | - | |
504 | | - | |
505 | | - | |
506 | | - | |
507 | | - | |
508 | | - | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | 498 | | |
0 commit comments