Add audio_in and audio_out to client map for DoCommand#46
Closed
Conversation
Member
|
This is also resolved in #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
AudioInClientandAudioOutCliententries to theclientMapinsrc/lib/client-map.tssoclientForBuiltinResource()resolves the correct gRPC client forrdk:component:audio_inandrdk:component:audio_out.DoCommandWidgetcallsclientForBuiltinResourceinternally — without these entries the widget receivesundefinedand throws a TypeError when a user opens the audio DoCommand card on a live machine.Companion PR (app-side
resourceMapchange that makes the card render): viamrobotics/app#11833. Fixes the bug tgritter flagged in review on that PR. Once this is released, the app-side version pin will be bumped.